feat: Add Math API stubs for ECRecover. (#3921)

near · Mar 26, 2021 · 9501198 · 9501198
1 parent a7d264f
commit 9501198
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 0 deletions.
diff --git a/core/primitives-core/src/config.rs b/core/primitives-core/src/config.rs
@@ -233,6 +233,11 @@ pub struct ExtCostsConfig {
  /// Cost of getting blake2b per byte
  pub blake2b_byte: Gas,
 
+ /// Cost of getting ecrecover base
+ pub ecrecover_base: Gas,
+ /// Cost of getting ecrecover per byte
+ pub ecrecover_byte: Gas,
+
  /// Cost for calling logging.
  pub log_base: Gas,
  /// Cost for logging per byte
@@ -367,6 +372,8 @@ impl Default for ExtCostsConfig {
  ripemd160_byte: SAFETY_MULTIPLIER * 8039117, // TODO
  blake2b_base: SAFETY_MULTIPLIER * 1513656750, // TODO
  blake2b_byte: SAFETY_MULTIPLIER * 8039117, // TODO
+ ecrecover_base: SAFETY_MULTIPLIER * 1000000000, // TODO
+ ecrecover_byte: SAFETY_MULTIPLIER * 1000000000, // TODO
  log_base: SAFETY_MULTIPLIER * 1181104350,
  log_byte: SAFETY_MULTIPLIER * 4399597,
  storage_write_base: SAFETY_MULTIPLIER * 21398912000,
@@ -441,6 +448,8 @@ impl ExtCostsConfig {
  ripemd160_byte: 0,
  blake2b_base: 0,
  blake2b_byte: 0,
+ ecrecover_base: 0,
+ ecrecover_byte: 0,
  log_base: 0,
  log_byte: 0,
  storage_write_base: 0,
@@ -516,6 +525,8 @@ pub enum ExtCosts {
  ripemd160_byte,
  blake2b_base,
  blake2b_byte,
+ ecrecover_base,
+ ecrecover_byte,
  log_base,
  log_byte,
  storage_write_base,
@@ -638,6 +649,8 @@ impl ExtCosts {
  ripemd160_byte => config.ripemd160_byte,
  blake2b_base => config.blake2b_base,
  blake2b_byte => config.blake2b_byte,
+ ecrecover_base => config.ecrecover_base,
+ ecrecover_byte => config.ecrecover_byte,
  log_base => config.log_base,
  log_byte => config.log_byte,
  storage_write_base => config.storage_write_base,
@@ -714,6 +727,8 @@ impl ExtCosts {
  "ripemd160_byte",
  "blake2b_base",
  "blake2b_byte",
+ "ecrecover_base",
+ "ecrecover_byte",
  "log_base",
  "log_byte",
  "storage_write_base",

diff --git a/runtime/near-vm-logic/src/logic.rs b/runtime/near-vm-logic/src/logic.rs
@@ -992,6 +992,21 @@ impl<'a> VMLogic<'a> {
  self.internal_write_register(register_id, value_hash.as_slice().to_vec())
  }
 
+ /// TODO
+ ///
+ /// # Errors
+ ///
+ /// TODO
+ ///
+ /// # Cost
+ ///
+ /// TODO
+ pub fn ecrecover(&mut self, hash_ptr: u64, v: u8, r_ptr: u64, s_ptr: u64, register_id: u64) -> Result<()> {
+ self.gas_counter.pay_base(ecrecover_base)?;
+
+ Ok(()) // TODO
+ }
+
  /// Called by gas metering injected into Wasm. Counts both towards `burnt_gas` and `used_gas`.
  ///
  /// # Errors

diff --git a/runtime/near-vm-logic/tests/test_miscs.rs b/runtime/near-vm-logic/tests/test_miscs.rs
@@ -593,6 +593,11 @@ fn test_blake2b() {
  });
 }
 
+#[test]
+fn test_ecrecover() {
+ // TODO
+}
+
 #[test]
 fn test_hash256_register() {
  let mut logic_builder = VMLogicBuilder::default();

diff --git a/runtime/near-vm-runner/src/imports.rs b/runtime/near-vm-runner/src/imports.rs
@@ -223,6 +223,7 @@ wrapped_imports! {
  keccak512<[value_len: u64, value_ptr: u64, register_id: u64] -> []>,
  ripemd160<[value_len: u64, value_ptr: u64, register_id: u64] -> []>,
  blake2b<[value_len: u64, value_ptr: u64, register_id: u64] -> []>,
+ ecrecover<[hash_ptr: u64, v: u8, r_ptr: u64, s_ptr: u64, register_id: u64] -> []>,
  // #####################
  // # Miscellaneous API #
  // #####################

diff --git a/runtime/runtime-params-estimator/src/cases.rs b/runtime/runtime-params-estimator/src/cases.rs
@@ -752,6 +752,8 @@ fn get_ext_costs_config(measurement: &Measurements, config: &Config) -> ExtCosts
  ripemd160_byte: measured_to_gas(metric, &measured, ripemd160_byte),
  blake2b_base: measured_to_gas(metric, &measured, blake2b_base),
  blake2b_byte: measured_to_gas(metric, &measured, blake2b_byte),
+ ecrecover_base: measured_to_gas(metric, &measured, ecrecover_base),
+ ecrecover_byte: measured_to_gas(metric, &measured, ecrecover_byte),
  log_base: measured_to_gas(metric, &measured, log_base),
  log_byte: measured_to_gas(metric, &measured, log_byte),
  storage_write_base: measured_to_gas(metric, &measured, storage_write_base),