Skip to content

Commit

Permalink
fix: Don't drop message for small cache size
Browse files Browse the repository at this point in the history
fix #2756

Increased route back cache to avoid dropping messages which
are supposed to be routed back. The problem was that when some
nodes are syncing several chunk request are asked, and request
arrive faster than responses, effectively invalidating the cache
most of the  responses are dropped, since the route back hash was
dropped from the cache.

Note: This is a vector of attack if we rely on route-back-messages,
since malicious actor can feed the cache with new information,
effectively invalidating our current cache.

Test plan
=========
Reproduced this scenario locally, and tested with and without the cache.
  • Loading branch information
mfornet committed Jun 10, 2020
1 parent 36cae31 commit 98bccda
Show file tree
Hide file tree
Showing 2 changed files with 354 additions and 721 deletions.
Loading

0 comments on commit 98bccda

Please sign in to comment.