-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Wasmer to 0.17.0 and upgrade downcasting of errors #2055
Comments
Ok, isolated it to having prints in my contracts. The "used access key requires" is different errors, both in nearlib and somewhere else. Investigating. |
Filed the error as separate issue in nearlib - near/near-api-js#210 |
The first part:
Might be related to Wasm Traps. It should be addressed by near/near-sdk-rs#73 |
@evgenykuzyakov can you test and closed if it's fixed? |
I think it is still happening. I asked Wasmer to clarify why is it happening. This is blocked by Wasmer response and therefore I assigned pessimistic ETA in case modifications in Wasmer are needed. |
I'm not working on this |
Blocked by: wasmerio/wasmer#1328 |
Should be resolved by #2316 |
Unfortunately, Wasmer doesn't return ExceptionCode's today (for single pass backend). Let's wait for wasmerio/wasmer#1328 |
More context: |
Blocked by wasmerio/wasmer#1338 |
Seems due to rust-lang/rust#68905 we have to update the Rust toolchain. |
nightly-2020-05-16 works fine. |
Fixes #2055 Test plan --------- cargo test --all
Used https://crates.io/crates/rust-latest to find latest suitable nightly. Fixes #2055 Test plan --------- cargo test --all
Used https://crates.io/crates/rust-latest to find latest suitable nightly. Fixes #2055 Test plan --------- cargo test --all
Used https://crates.io/crates/rust-latest to find latest suitable nightly. Fixes #2055 Test plan --------- cargo test --all
Used https://crates.io/crates/rust-latest to find latest suitable nightly. Fixes #2055 Test plan --------- cargo test --all
Used https://crates.io/crates/rust-latest to find latest suitable nightly. Fixes #2055 Test plan --------- cargo test --all
Used https://crates.io/crates/rust-latest to find latest suitable nightly. Fixes #2055 Test plan --------- cargo test --all
Used https://crates.io/crates/rust-latest to find latest suitable nightly. Fixes #2055 Test plan --------- cargo test --all
Used https://crates.io/crates/rust-latest to find latest suitable nightly. Fixes #2055 Test plan --------- cargo test --all
Used https://crates.io/crates/rust-latest to find latest suitable nightly. Fixes #2055 Test plan --------- cargo test --all
Used https://crates.io/crates/rust-latest to find latest suitable nightly. Fixes #2055 Test plan --------- cargo test --all
We need to upgrade to Wasmer 0.17.0 and upgrade downcasting of errors such that we can diffirentiate between host and guest panics, see: wasmerio/wasmer#1328.
0.17.0 also includes fixes for the following critical bugs:
wasmerio/wasmer#1436
wasmerio/wasmer#1412
And it includes NaN canonicalization: wasmerio/wasmer#1303
For more context see #2316 (comment) . Currently we are printing "unknown" error all the time. See the report below.
Receiving output in nearcore:
Steps to repro:
my_validator
andacc1
. Deposit100
NEAR toacc1
.near call my_validator deposit '' --account_id acc1 --amount 10
Output from near:
The text was updated successfully, but these errors were encountered: