Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node keeps trying to connect to itself #2601

Closed
ilblackdragon opened this issue May 2, 2020 · 1 comment · Fixed by #2603
Closed

Node keeps trying to connect to itself #2601

ilblackdragon opened this issue May 2, 2020 · 1 comment · Fixed by #2603
Assignees
@mfornet
Labels
A-network Area: Network

Comments

@ilblackdragon
Copy link
Member

ilblackdragon commented May 2, 2020 •
edited
Loading

Describe the bug
Node keep reporting that keep connecting to itself and report warning that it received info about itself.

May 02 11:38:10.788  WARN network: Received info about itself. Disconnecting this peer.
May 02 11:38:10.849  WARN network: Received info about itself. Disconnecting this peer.
May 02 11:38:11.092  WARN network: Received info about itself. Disconnecting this peer.
May 02 11:38:12.644  WARN network: Received info about itself. Disconnecting this peer.

Expected behavior
At most this happens once, ideally doesn't happen at all, because we shouldn't be sending our peer info to ourselves and should determine that peerId is ours and not include it into peer table.
@ilblackdragon ilblackdragon added the A-network Area: Network label May 2, 2020
@ilblackdragon ilblackdragon changed the title Keep receiving info about yourself from peers Noe keeps trying to connect to itself May 2, 2020
@bowenwang1996 bowenwang1996 changed the title Noe keeps trying to connect to itself Node keeps trying to connect to itself May 2, 2020
@bowenwang1996
Copy link
Collaborator

@mfornet I thought this is already fixed?

@mfornet mfornet mentioned this issue May 2, 2020
Merged
nearprotocol-bulldozer bot pushed a commit that referenced this issue May 5, 2020
@mfornet
fix(network): Avoid peers connecting to itself. (#2603)
c3bac90 
If a node receives info about itself from other nodes
it was possible it tries to establish connection with itself.

Fix #2601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfornet mfornet

Labels
A-network Area: Network
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(network): Avoid peers connecting to itself. near/nearcore
3 participants
@ilblackdragon @bowenwang1996 @mfornet