Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator with wrong key should not be able to produce blocks #2682

Closed
bowenwang1996 opened this issue May 19, 2020 · 1 comment
Closed

Validator with wrong key should not be able to produce blocks #2682

bowenwang1996 opened this issue May 19, 2020 · 1 comment

Comments

@bowenwang1996
Copy link
Collaborator

Currently if a validator's local validator key doesn't match the key they have staked with, they can still produce blocks but will get banned for doing this. It is suboptimal for two reasons:

  • The proposal for upgradability Initial spec for upgradability NEPs#64 depends on having two node with different validator keys running at the same time and only one of them validating at any given moment.
  • If a validator uses the wrong key, it is hard for them to tell what happened.
@bowenwang1996 bowenwang1996 mentioned this issue May 19, 2020
Merged
bowenwang1996 added a commit that referenced this issue May 20, 2020
@bowenwang1996
fix: validator with wrong key should not be able to produce blocks (#…
649d1b2 
…2683)

See #2682 for the issue description. Now if a validator with incorrect key tries to produce a block they will fail with an error printed in the log indicating that they have the wrong validator key.

Test plan
---------
`test_incorrect_validator_key_produce_block` passes.
@bowenwang1996
Copy link
Collaborator Author

Fixed in #2683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bowenwang1996