Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring current protocol costs in-line with current parameter estimator implementation #4474

Open
matklad opened this issue Jul 8, 2021 · 2 comments
Labels
A-params-estimator Area: runtime params estimator T-contract-runtime Team: issues relevant to the contract runtime team

Comments

@matklad
Copy link
Contributor

matklad commented Jul 8, 2021

Historically, we only measured number of CPU instructions executed when calculating costs. This is the implementation which was used to derive the current set of costs.

Then, in #3771, we implemented the logic to also account for the cost of IO operations (by measuring the total number of bytes read/written, and adding them with some coeficient to the instruction counter).

Crucially though, we didn't actually update the costs after that work (the PR to do this isn't merged: #3818). That means that, if you run parameter estimeator today, you get a wildly different costs from the status quo. Current costs doesn't account for IO, but the estimator does.

This is a significant amount of technical dept: if we want to change some cost today, we can't just run parameter estimator and look at the diff, as that would be comparing apples and oranges.

@stale
Copy link

stale bot commented Oct 6, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 4, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Apr 4, 2022
@jakmeier jakmeier removed the S-stale label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-params-estimator Area: runtime params estimator T-contract-runtime Team: issues relevant to the contract runtime team
Projects
None yet
Development

No branches or pull requests

2 participants