-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take IO costs into account #3771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olonho
force-pushed
the
io_costs_prod2
branch
2 times, most recently
from
December 23, 2020 15:46
5439914
to
be4e68f
Compare
IO not taken into account
|
IO taken into account
|
Comparison:
|
So significant changes are:
|
Recomputed after merging #3505. No IO costs:
With IO costs
Significant difference:
|
olonho
force-pushed
the
io_costs_prod2
branch
from
January 15, 2021 06:27
2397489
to
b57b3d4
Compare
olonho
force-pushed
the
io_costs_prod2
branch
from
January 15, 2021 06:34
b57b3d4
to
36374f8
Compare
willemneal
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one nit.
ailisp
approved these changes
Jan 15, 2021
olonho
force-pushed
the
io_costs_prod2
branch
from
January 16, 2021 15:00
6d0327e
to
5a34b29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.