Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using lazy_static with near_metrics::Result<IntCounter>> #5317

Closed
3 of 4 tasks
pmnoxx opened this issue Nov 17, 2021 · 1 comment
Closed
3 of 4 tasks

Stop using lazy_static with near_metrics::Result<IntCounter>> #5317

pmnoxx opened this issue Nov 17, 2021 · 1 comment

Comments

@pmnoxx
Copy link
Contributor

pmnoxx commented Nov 17, 2021 •
edited
Loading

We should continue #5265
and stop using Lazy<near_metrics::Result<IntCounter>> and replace with Lazy<IntCounter> everywhere.

@matklad

Progress
@pmnoxx pmnoxx self-assigned this Nov 17, 2021
This was referenced Nov 17, 2021
Merged
Merged
@pmnoxx pmnoxx changed the title Stop using Lazy<near_metrics::Result<IntCounter>> Stop using lazy_static with near_metrics::Result<IntCounter>> Nov 17, 2021
@pmnoxx pmnoxx mentioned this issue Nov 17, 2021
Merged
near-bulldozer bot pushed a commit that referenced this issue Nov 18, 2021
@pmnoxx
refactor: stop using lazy_static inside chain/json* (#5323)
3a730f3 
This is part of #5317 PR, extracted just for chain/json* files.
near-bulldozer bot pushed a commit that referenced this issue Nov 19, 2021
@pmnoxx
refactor: Remove usage of lazy_static! not neard files (#5321)
faefb0b 
Full change for removing `Lazy` and usage of `metrics::Result`.

See #5317

I'm splitting this PR into smaller ones. I'll do more split as more RPs get merged.
- [x] 19 files chain/jsonrpc #5323
- [x] 11 files chain #5318 
- [x] 10 files core only #5366
- [x] 3 files runtime #5367
- [x] 8 files other places #5321
- [x] Remove unused methods in metrics #5374
near-bulldozer bot pushed a commit that referenced this issue Nov 24, 2021
@pmnoxx
refactor: Remove usage of lazy_static! from chain (#5318)
3515193 
This is continuation of #5317
This time we will format metrics in `chain/chain/src/metrics.rs` file.

Part of PR: https://github.com/near/nearcore/pull/5321/files
pmnoxx added a commit that referenced this issue Nov 25, 2021
@pmnoxx
refactor: Remove usage of lazy_static! from chain (#5318)
f8eb1d6 
This is continuation of #5317
This time we will format metrics in `chain/chain/src/metrics.rs` file.

Part of PR: https://github.com/near/nearcore/pull/5321/files
pmnoxx added a commit that referenced this issue Nov 25, 2021
@pmnoxx
refactor: Remove usage of lazy_static! from chain (#5318)
7c4ed7a 
This is continuation of #5317
This time we will format metrics in `chain/chain/src/metrics.rs` file.

Part of PR: https://github.com/near/nearcore/pull/5321/files
@stale
Copy link

stale bot commented Feb 15, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Feb 15, 2022
@pmnoxx pmnoxx removed their assignment Mar 7, 2022
@stale stale bot removed the S-stale label Mar 7, 2022
@pmnoxx pmnoxx closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmnoxx