feat: Implement measuring of network round-trip time for sending state witness and receiving the ack #10824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess and receiving the ack.
pugachAG
requested changes
Mar 18, 2024
chain/client/src/stateless_validation/state_witness_producer.rs
Outdated
Show resolved
Hide resolved
chain/client/src/stateless_validation/state_witness_producer.rs
Outdated
Show resolved
Hide resolved
chain/client/src/stateless_validation/state_witness_producer.rs
Outdated
Show resolved
Hide resolved
akhi3030
approved these changes
Mar 19, 2024
chain/client/src/stateless_validation/state_witness_producer.rs
Outdated
Show resolved
Hide resolved
nagisa
reviewed
Mar 19, 2024
nagisa
reviewed
Mar 19, 2024
chain/client/src/stateless_validation/state_witness_producer.rs
Outdated
Show resolved
Hide resolved
wacban
reviewed
Mar 19, 2024
|
How will 'send_state_witness_ack' work if we decide to implement multi-hop strategy? It will be great for us to outline assumptions we are making with the approach |
Co-authored-by: Akhilesh Singhania <akhi@near.org>
Co-authored-by: Akhilesh Singhania <akhi@near.org>
Co-authored-by: Akhilesh Singhania <akhi@near.org>
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
wacban
reviewed
Mar 20, 2024
…lmas/nearcore into witness-roundtrip-metric
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10824 +/- ##
==========================================
- Coverage 71.43% 71.42% -0.01%
==========================================
Files 763 764 +1
Lines 153722 153894 +172
Branches 153722 153894 +172
==========================================
+ Hits 109807 109917 +110
- Misses 38919 38974 +55
- Partials 4996 5003 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to measure the network time spent (see issue #10790)
1 when sending state-witness from chunk producers to validators and
2 when sending the endorsement message from chunk validators to block producers.
But, for (2), we send an ack message (
ChunkStateWitness) from the validator back to the chunk producer. This is not fully accurate but should give us some picture of the duration. We do not change the state-witness time to record the sent-time. Instead we keep the sent-time in the chunk producer (for which we addChunkStateWitnessTrackerto theClient) along with the hash of the chunk for which witness is created. Then upon receiving the ack message, we calculate the duration and store it in a metric in the chunk producer.Most of the logic is in
state_witness_tracker.rs. Note that this implementation is for experimenting with network time estimates for now and, since we are not changing the witness messages, having ack messages is optional and we may remove it later when we have a stable implementation. We have not added a feature flag for it (though guarded bystatelessnet_protocol) and may want to add a compile flag later before releasingstatelessnet_protocolin mainnet.Note that we make the assumption that the messages are directly sent between nodes (no intermediary hop node).