Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Describe congestion fundamentals #10873
docs: Describe congestion fundamentals #10873
Changes from 3 commits
082bae5
5a7cf41
c2117e9
7592439
d642476
690059d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on how it's interpreted the graph may also need a 999 Tgas arrow from shard 3 to itself and then the arrow to sink should be 2997 Tgas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for the graph below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree for the arrow shard3 -> shard3. But I think it should still be 2998 Tgas. Otherwise the sum of flows from the source is not equal to the sum to the sinks. It would be 2997 Tgas for the receipts and 1 Tgas for conversion, both should point to sink, showing that the gas has been burnt.
I'm adding the arrows to the two graphs as best as I can without it getting too unreadable... Aligning things isn't always easy in graphviz graphs^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the other way around, a strategy that accepts more than this limit will have unbounded queues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right^^ I think a "not" went missing somewhere, I'll add one to correct it.