-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable prefetch and shard cache when memtrie is enabled #11965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11965 +/- ##
==========================================
- Coverage 71.58% 71.51% -0.08%
==========================================
Files 808 812 +4
Lines 163537 164467 +930
Branches 163537 164467 +930
==========================================
+ Hits 117071 117619 +548
- Misses 41386 41687 +301
- Partials 5080 5161 +81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pugachAG
changed the title
feat: disable prefetch when memtrie is enabled
feat: disable prefetch and shard cache when memtrie is enabled
Aug 20, 2024
tayfunelmas
reviewed
Aug 21, 2024
tayfunelmas
reviewed
Aug 21, 2024
tayfunelmas
reviewed
Aug 21, 2024
tayfunelmas
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11912.
See zulip thread for more context around removing prefetcher.
Shard cache is removed since it doesn't provide any additional caching on top of memtrie since
TRIE_LIMIT_CACHED_VALUE_SIZE
value is lower thanINLINE_DISK_VALUE_THRESHOLD
. This was confirmed bynear_shard_cache_hits
metric.