Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable prefetch and shard cache when memtrie is enabled #11965

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

pugachAG
Copy link
Contributor

@pugachAG pugachAG commented Aug 19, 2024

Part of #11912.

See zulip thread for more context around removing prefetcher.

Shard cache is removed since it doesn't provide any additional caching on top of memtrie since TRIE_LIMIT_CACHED_VALUE_SIZE value is lower than INLINE_DISK_VALUE_THRESHOLD. This was confirmed by near_shard_cache_hits metric.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.51%. Comparing base (6412f22) to head (8c32e00).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11965      +/-   ##
==========================================
- Coverage   71.58%   71.51%   -0.08%     
==========================================
  Files         808      812       +4     
  Lines      163537   164467     +930     
  Branches   163537   164467     +930     
==========================================
+ Hits       117071   117619     +548     
- Misses      41386    41687     +301     
- Partials     5080     5161      +81     
Flag Coverage Δ
backward-compatibility 0.23% <0.00%> (-0.01%) ⬇️
db-migration 0.23% <0.00%> (-0.01%) ⬇️
genesis-check 1.34% <0.00%> (+<0.01%) ⬆️
integration-tests 38.44% <97.61%> (-0.02%) ⬇️
linux 71.27% <100.00%> (-0.09%) ⬇️
linux-nightly 71.11% <100.00%> (-0.04%) ⬇️
macos 54.25% <100.00%> (-0.13%) ⬇️
pytests 1.60% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.41% <0.00%> (+<0.01%) ⬆️
unittests 65.46% <100.00%> (-0.21%) ⬇️
upgradability 0.27% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pugachAG pugachAG changed the title feat: disable prefetch when memtrie is enabled feat: disable prefetch and shard cache when memtrie is enabled Aug 20, 2024
@pugachAG pugachAG marked this pull request as ready for review August 20, 2024 13:47
@pugachAG pugachAG requested a review from a team as a code owner August 20, 2024 13:47
@pugachAG pugachAG linked an issue Aug 20, 2024 that may be closed by this pull request
@pugachAG pugachAG enabled auto-merge August 23, 2024 14:44
@pugachAG pugachAG added this pull request to the merge queue Aug 23, 2024
Merged via the queue into master with commit 0c23749 Aug 23, 2024
29 of 30 checks passed
@pugachAG pugachAG deleted the disable-prefetch-memtries branch August 23, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project tracking] Remove obsolete storage optimisations
2 participants