[fix] Always use latest ETH wallet contract #12038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyan-gupta
commented
Sep 4, 2024
| if checked_feature!("stable", EthImplicitAccounts, version) | ||
| && account_id.get_account_type() == AccountType::EthImplicitAccount | ||
| && code_hash_matches_wallet_contract(chain_id, &code_hash, version) |
There was a problem hiding this comment.
todo: Verify if it is fine to remove this check
There was a problem hiding this comment.
We actually cannot remove this check because not all accounts that look like eth-implicit have the wallet contract magic bytes (see details in this PR description).
tayfunelmas
reviewed
Sep 4, 2024
| @@ -379,11 +379,12 @@ impl<'a> Contract for RuntimeContractExt<'a> { | |||
| let code_hash = self.hash(); | |||
| let version = self.current_protocol_version; | |||
| let chain_id = self.chain_id; | |||
| // We are removing the check to match code_hash_matches_wallet_contract | |||
There was a problem hiding this comment.
nit. once you remove the code below, this comment will not refer to any check after merging.
|
Can you provide more context?
|
birchmd
requested changes
Sep 4, 2024
| if checked_feature!("stable", EthImplicitAccounts, version) | ||
| && account_id.get_account_type() == AccountType::EthImplicitAccount | ||
| && code_hash_matches_wallet_contract(chain_id, &code_hash, version) |
There was a problem hiding this comment.
We actually cannot remove this check because not all accounts that look like eth-implicit have the wallet contract magic bytes (see details in this PR description).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was originally a bug fix to the ETH contract code
This PR removes the check for protocol version >= 71 and < 71 and always tries to load the latest wallet contract code for ETH implicit accounts