wallet_contract now returns contract based on the hash
#12041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hash is stored in the `Account` and the rest of the codebase largely expects the hash to uniquely identify the specific contract code. For the time being just return exactly what's stored in the `Account` and think about updating the accounts later...
pugachAG
approved these changes
Sep 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12041 +/- ##
==========================================
- Coverage 71.51% 71.50% -0.02%
==========================================
Files 814 814
Lines 164513 164465 -48
Branches 164513 164465 -48
==========================================
- Hits 117648 117593 -55
- Misses 41699 41703 +4
- Partials 5166 5169 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
birchmd
approved these changes
Sep 4, 2024
birchmd
requested changes
Sep 4, 2024
jancionear
reviewed
Sep 4, 2024
birchmd
approved these changes
Sep 4, 2024
VanBarbascu
reviewed
Sep 4, 2024
| } | ||
| _ => LOCALNET.read_contract(), |
There was a problem hiding this comment.
This allowed the LOCALNET contract to be deployed on test chains. i.e. mocknet. What contract will be picked in this case?
staffik
pushed a commit
that referenced
this pull request
Sep 5, 2024
Hash is stored in the `Account` and the rest of the codebase largely expects the hash to uniquely identify the specific contract code. For the time being just return exactly what's stored in the `Account` and think about updating the accounts later...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash is stored in the
Accountand the rest of the codebase largely expects the hash to uniquely identify the specific contract code. For the time being just return exactly what's stored in theAccountand think about updating the accounts later...