Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[memtrie] Introduce HybridArena and FrozenArena #12075

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

shreyan-gupta
Copy link
Contributor

Review this PR after #12073

This PR introduces HybridArena which represents a combination of owned and shared memory.

This is useful during resharding to create temporary memtries for the children of a split parent shard.

@shreyan-gupta shreyan-gupta requested a review from a team as a code owner September 11, 2024 08:50
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 95.13889% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.62%. Comparing base (cf47d81) to head (68e457d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
core/store/src/trie/mem/arena/hybrid.rs 96.52% 3 Missing and 1 partial ⚠️
core/store/src/trie/mem/arena/frozen.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12075      +/-   ##
==========================================
+ Coverage   71.60%   71.62%   +0.01%     
==========================================
  Files         816      818       +2     
  Lines      164337   164468     +131     
  Branches   164337   164468     +131     
==========================================
+ Hits       117676   117800     +124     
- Misses      41525    41528       +3     
- Partials     5136     5140       +4     
Flag Coverage Δ
backward-compatibility 0.17% <0.00%> (-0.01%) ⬇️
db-migration 0.17% <0.00%> (-0.01%) ⬇️
genesis-check 1.26% <0.00%> (-0.01%) ⬇️
integration-tests 38.73% <34.02%> (+<0.01%) ⬆️
linux 71.21% <95.13%> (+<0.01%) ⬆️
linux-nightly 71.14% <95.13%> (+0.02%) ⬆️
macos 54.00% <95.13%> (-0.10%) ⬇️
pytests 1.53% <0.00%> (-0.01%) ⬇️
sanity-checks 1.33% <0.00%> (-0.01%) ⬇️
unittests 65.40% <95.13%> (+0.02%) ⬆️
upgradability 0.22% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@robin-near robin-near left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is pretty clean!

Base automatically changed from shreyan/memtrie/simplify_interface to master September 12, 2024 21:48
@shreyan-gupta shreyan-gupta added this pull request to the merge queue Sep 12, 2024
Merged via the queue into master with commit cb5efd6 Sep 12, 2024
28 of 29 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/memtrie/hybrid branch September 12, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants