-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[memtrie] Introduce HybridArena and FrozenArena #12075
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12075 +/- ##
==========================================
+ Coverage 71.60% 71.62% +0.01%
==========================================
Files 816 818 +2
Lines 164337 164468 +131
Branches 164337 164468 +131
==========================================
+ Hits 117676 117800 +124
- Misses 41525 41528 +3
- Partials 5136 5140 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is pretty clean!
Review this PR after #12073
This PR introduces HybridArena which represents a combination of owned and shared memory.
This is useful during resharding to create temporary memtries for the children of a split parent shard.