Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resharding): flat storage resharding mvp #12164
feat(resharding): flat storage resharding mvp #12164
Changes from 22 commits
51f9f44
eb421de
c1a71a6
9234160
c39b476
f977326
d6823d3
0195907
c7a6875
4c7e9b2
79730a4
ad83e0b
ae82453
e735755
fc38090
75c42b5
3848c40
306c502
b9f11d4
7fe014e
d02fc52
cf8ec95
f45cc9e
3c188c5
ac6d642
9269c37
7ad602e
d0b3125
df869fc
e1f3b5d
6d4188c
d6b5ab3
c52b947
f542962
7670129
a3849a2
17538f9
ebd144a
4468660
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't completely understand why is flat_storage_resharder a part of FlatStorageCreator? The FlatStorageCreator is created at the time of calling new() in client. The
Self::create_flat_storage_for_current_epoch
is also thus called only in the beginning right? How do we later set the status of some flat storage toFlatStorageStatus::Resharding
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically the
FlatStorageResharder
is part of client.FlatStorageCreator
uses a reference to the resharder to handle the case when the node restarts and flat storage resharding was in progress. I did like this because the creator already has logic to handle resuming flat storage from the previous state.In normal flow the resharding of flat storage would be initiated by the resharding manager, but that part is not done yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a todo for this PR or later? I'm fine with later but I just saw that the resume method is already implemented so might as well call it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is meant for a second PR, I'll need to see how to link everything together