Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(state sync): delete get_cached_state_parts #12197

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

saketh-are
Copy link
Collaborator

In testnet we observed get_cached_state_parts consistently taking ~58 seconds to run.

Returning the list of cached state parts is a relic of the old decentralized state sync design. We no longer need this at all.

@saketh-are saketh-are marked this pull request as ready for review October 9, 2024 10:19
@saketh-are saketh-are requested a review from a team as a code owner October 9, 2024 10:19
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.67%. Comparing base (d0a33c3) to head (3085ff2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12197      +/-   ##
==========================================
- Coverage   71.69%   71.67%   -0.02%     
==========================================
  Files         824      824              
  Lines      165526   165484      -42     
  Branches   165526   165484      -42     
==========================================
- Hits       118670   118616      -54     
- Misses      41709    41734      +25     
+ Partials     5147     5134      -13     
Flag Coverage Δ
backward-compatibility 0.17% <ø> (+<0.01%) ⬆️
db-migration 0.17% <ø> (+<0.01%) ⬆️
genesis-check 1.26% <ø> (+<0.01%) ⬆️
integration-tests 38.83% <ø> (-0.05%) ⬇️
linux 71.37% <ø> (-0.02%) ⬇️
linux-nightly 71.26% <ø> (-0.02%) ⬇️
macos 53.53% <ø> (+0.60%) ⬆️
pytests 1.57% <ø> (+<0.01%) ⬆️
sanity-checks 1.38% <ø> (+<0.01%) ⬆️
unittests 65.34% <ø> (+0.02%) ⬆️
upgradability 0.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saketh-are saketh-are added this pull request to the merge queue Oct 9, 2024
Merged via the queue into near:master with commit 2d5dd96 Oct 9, 2024
29 of 30 checks passed
@saketh-are saketh-are deleted the kill_get_cached_state_parts branch October 9, 2024 15:15
marcelo-gonzalez pushed a commit to marcelo-gonzalez/nearcore that referenced this pull request Oct 10, 2024
In testnet we observed `get_cached_state_parts` consistently taking ~58
seconds to run.

Returning the list of cached state parts is a relic of the old
decentralized state sync design. We no longer need this at all.
@marcelo-gonzalez marcelo-gonzalez mentioned this pull request Oct 10, 2024
marcelo-gonzalez added a commit that referenced this pull request Oct 10, 2024
bump version string and cherry pick
#12197

---------

Co-authored-by: Saketh Are <saketh.are@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants