-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(congestion_control) - relax congestion control #12241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
approved these changes
Oct 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12241 +/- ##
==========================================
- Coverage 71.61% 71.61% -0.01%
==========================================
Files 836 836
Lines 167418 167423 +5
Branches 167418 167423 +5
==========================================
- Hits 119903 119892 -11
- Misses 42283 42297 +14
- Partials 5232 5234 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per zulip discussion congestion control seems to be too aggressive.
This is relaxing two parameters:
reject_tx_congestion_threshold
bumped from 50% to 70%. It means that new transactions will only be rejected once the congestion level reaches 70%.Both parameters are picked pretty arbitrarily and there is no science behind it.
I am not increasing the outgoing or memory limits as they don't seem to be the bottleneck.