Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(congestion_control) - relax congestion control #12241

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Conversation

wacban
Copy link
Contributor

@wacban wacban commented Oct 17, 2024

As per zulip discussion congestion control seems to be too aggressive.

This is relaxing two parameters:

  • The max gas in the delayed receipts queue increased twofold-> this will allow the queue to grow larger and buffer more receipts to handle spikes in traffic better. The tradeoff is that the queue will be larger and the transaction processing time will be slower during those periods.
  • The reject_tx_congestion_threshold bumped from 50% to 70%. It means that new transactions will only be rejected once the congestion level reaches 70%.

Both parameters are picked pretty arbitrarily and there is no science behind it.

I am not increasing the outgoing or memory limits as they don't seem to be the bottleneck.

@wacban wacban requested a review from bowenwang1996 October 17, 2024 12:54
@wacban wacban requested a review from a team as a code owner October 17, 2024 12:54
@wacban wacban enabled auto-merge October 17, 2024 20:53
@wacban wacban disabled auto-merge October 17, 2024 22:42
@wacban wacban added this pull request to the merge queue Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.61%. Comparing base (8ba5ed1) to head (f22713c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12241      +/-   ##
==========================================
- Coverage   71.61%   71.61%   -0.01%     
==========================================
  Files         836      836              
  Lines      167418   167423       +5     
  Branches   167418   167423       +5     
==========================================
- Hits       119903   119892      -11     
- Misses      42283    42297      +14     
- Partials     5232     5234       +2     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (ø)
db-migration 0.16% <0.00%> (ø)
genesis-check 1.25% <0.00%> (-0.01%) ⬇️
integration-tests 38.84% <57.14%> (-0.02%) ⬇️
linux 71.27% <100.00%> (+<0.01%) ⬆️
linux-nightly 71.20% <100.00%> (-0.01%) ⬇️
macos 54.27% <100.00%> (+0.02%) ⬆️
pytests 1.57% <0.00%> (-0.01%) ⬇️
sanity-checks 1.37% <0.00%> (-0.01%) ⬇️
unittests 65.38% <100.00%> (-0.01%) ⬇️
upgradability 0.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@wacban wacban enabled auto-merge October 18, 2024 14:35
@wacban wacban added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@wacban wacban enabled auto-merge October 21, 2024 13:05
@wacban wacban added this pull request to the merge queue Oct 21, 2024
Merged via the queue into master with commit f198d5a Oct 21, 2024
29 checks passed
@wacban wacban deleted the waclaw-cc-relax branch October 21, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants