Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove header signature verification from epoch manager #12467

Merged
merged 15 commits into from
Dec 12, 2024

Conversation

stedfn
Copy link
Contributor

@stedfn stedfn commented Nov 15, 2024

No description provided.

@stedfn stedfn self-assigned this Nov 15, 2024
@stedfn stedfn changed the base branch from master to stefan/em_sig_ver November 15, 2024 14:20
@stedfn stedfn marked this pull request as ready for review November 15, 2024 16:08
@stedfn stedfn requested a review from a team as a code owner November 15, 2024 16:08
chain/chain/src/signature_verification.rs Outdated Show resolved Hide resolved
chain/chain/src/signature_verification.rs Outdated Show resolved Hide resolved
@stedfn stedfn changed the base branch from stefan/em_sig_ver to master November 20, 2024 13:12
@stedfn stedfn changed the base branch from master to stefan/remove_verify_chunk_header November 20, 2024 13:12
@stedfn stedfn changed the base branch from stefan/remove_verify_chunk_header to stefan/em_sig_ver November 20, 2024 13:13
Base automatically changed from stefan/em_sig_ver to master December 9, 2024 13:53
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.48%. Comparing base (544fa1f) to head (f78a67d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
chain/chain/src/chain.rs 80.00% 0 Missing and 1 partial ⚠️
chain/chain/src/validate.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12467   +/-   ##
=======================================
  Coverage   70.48%   70.48%           
=======================================
  Files         845      845           
  Lines      171976   171970    -6     
  Branches   171976   171970    -6     
=======================================
- Hits       121214   121211    -3     
+ Misses      45654    45651    -3     
  Partials     5108     5108           
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (+<0.01%) ⬆️
db-migration 0.16% <0.00%> (+<0.01%) ⬆️
genesis-check 1.28% <0.00%> (+<0.01%) ⬆️
linux 69.37% <85.71%> (-0.02%) ⬇️
linux-nightly 70.06% <85.71%> (+0.01%) ⬆️
pytests 1.59% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.40% <0.00%> (+<0.01%) ⬆️
unittests 70.31% <85.71%> (+<0.01%) ⬆️
upgradability 0.20% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stedfn stedfn added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 861c842 Dec 12, 2024
27 checks passed
@stedfn stedfn deleted the stefan/more_sig_ver_removal branch December 12, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants