Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip remove empty case from trie node #12478

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

stedfn
Copy link
Contributor

@stedfn stedfn commented Nov 19, 2024

No description provided.

@stedfn stedfn self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.85%. Comparing base (7dfdfb0) to head (5ab8ae7).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
core/store/src/trie/iterator.rs 92.85% 7 Missing ⚠️
core/store/src/trie/state_parts.rs 61.53% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12478       +/-   ##
===========================================
+ Coverage    1.60%   69.85%   +68.25%     
===========================================
  Files         667      838      +171     
  Lines      118468   169445    +50977     
  Branches   118468   169445    +50977     
===========================================
+ Hits         1897   118365   +116468     
+ Misses     116363    45828    -70535     
- Partials      208     5252     +5044     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (-0.01%) ⬇️
db-migration 0.16% <0.00%> (-0.01%) ⬇️
genesis-check 1.29% <0.00%> (-0.01%) ⬇️
linux 69.15% <89.18%> (+67.55%) ⬆️
linux-nightly 69.43% <89.18%> (?)
macos 51.02% <86.48%> (?)
pytests 1.60% <0.00%> (-0.01%) ⬇️
sanity-checks 1.40% <0.00%> (-0.01%) ⬇️
unittests 69.68% <89.18%> (?)
upgradability 0.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant