refactor: move more methods out of ValidatorSigner #12500
Merged
+49
−281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugachAG
force-pushed
the
clean-up-validator-signer
branch
from
492f7ad
to
140a5a0
Compare
tayfunelmas
approved these changes
Nov 22, 2024
pugachAG
force-pushed
the
clean-up-validator-signer
branch
from
140a5a0
to
c81185c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12500 +/- ##
==========================================
+ Coverage 69.84% 69.96% +0.11%
==========================================
Files 838 838
Lines 169410 169132 -278
Branches 169410 169132 -278
==========================================
+ Hits 118323 118326 +3
+ Misses 45840 45678 -162
+ Partials 5247 5128 -119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pugachAG
force-pushed
the
clean-up-validator-signer
branch
from
c81185c
to
7722116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finalises the effort started in #12422: all unnecessary methods are moved out of
ValidatorSignerto the client code.