Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draft] state sync changes #12501

Draft
wants to merge 31 commits into
base: 2.4.0-test-shard-shuffling
Choose a base branch
from
Draft

[draft] state sync changes #12501

wants to merge 31 commits into from

Commits on Nov 20, 2024

  1. sync from peers: distinguish error outcomes

    @saketh-are
    saketh-are committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    955d846 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. sync from external: fix source and distinguish errors

    @saketh-are
    saketh-are committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    be5637b View commit details
    Browse the repository at this point in the history

  2. randomize attempt order + try peers before cloud

    @saketh-are
    saketh-are committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3e36944 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. apply retry timeout for attempts to external

    @saketh-are
    saketh-are committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    72e34af View commit details
    Browse the repository at this point in the history

  2. get headers for all shards

    @saketh-are
    saketh-are committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b5fc25e View commit details
    Browse the repository at this point in the history

  3. fix(forknet): do not load the memtries on dumper node (#12460) 

    The dumper node is an RPC and tracks all shards, it does not need to
load memtries
    @VanBarbascu @saketh-are
    VanBarbascu authored and saketh-are committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    62a2a01 View commit details
    Browse the repository at this point in the history

  4. fix metric name

    @saketh-are
    saketh-are committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b88a759 View commit details
    Browse the repository at this point in the history

  5. add a couple of comments

    @saketh-are
    saketh-are committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    5c89b2a View commit details
    Browse the repository at this point in the history

  6. Revert "apply retry timeout for attempts to external" 

    This reverts commit 72e34af.
    @saketh-are
    saketh-are committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7772d09 View commit details
    Browse the repository at this point in the history

  7. add a cooldown for cloud requests

    @saketh-are
    saketh-are committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    8d7e856 View commit details
    Browse the repository at this point in the history

  8. bring back retry timeout for parts attempts

    @saketh-are
    saketh-are committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7cb3474 View commit details
    Browse the repository at this point in the history

  9. cargo fmt

    @saketh-are
    saketh-are committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d67e66f View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. add debug msg for header success

    @saketh-are
    saketh-are committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    c367cdc View commit details
    Browse the repository at this point in the history

  2. don't need header to make part

    @saketh-are
    saketh-are committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    59635d0 View commit details
    Browse the repository at this point in the history

  3. Revert "get headers for all shards" 

    This reverts commit b5fc25e.
    @saketh-are
    saketh-are committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    36f11be View commit details
    Browse the repository at this point in the history

  4. make backoff after download failure configurable

    @saketh-are
    saketh-are committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    d11323c View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2024

  1. apply external cooldown only upon error

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    51eec8c View commit details
    Browse the repository at this point in the history

  2. oops

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    eb11601 View commit details
    Browse the repository at this point in the history

  3. add metrics for state part cache

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    c710b4a View commit details
    Browse the repository at this point in the history

  4. adjust comment

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    b38114b View commit details
    Browse the repository at this point in the history

  5. adjust comment

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    600c2d4 View commit details
    Browse the repository at this point in the history

  6. cleanup

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    620e987 View commit details
    Browse the repository at this point in the history

  7. add return_if_cancelled in attempt loop

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    3cf638a View commit details
    Browse the repository at this point in the history

  8. rename var for clarity

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    9ab7c40 View commit details
    Browse the repository at this point in the history

  9. comment

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    b557662 View commit details
    Browse the repository at this point in the history

  10. don't attempt part download if cancelled

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    da838cb View commit details
    Browse the repository at this point in the history

  11. avoid cloning header for every part request

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    835b49a View commit details
    Browse the repository at this point in the history

  12. actually don't even pass the header

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    37b0074 View commit details
    Browse the repository at this point in the history

  13. introduce some adversity

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    411fd04 View commit details
    Browse the repository at this point in the history

  14. wow

    @saketh-are
    saketh-are committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    c8b3f94 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. i cant code

    @saketh-are
    saketh-are committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f44eb78 View commit details
    Browse the repository at this point in the history