Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(InMemorySinger) - test and test_signer methods application #12537

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

mkamonMdt
Copy link
Contributor

Two factory methods for InMemorySigner were provided in #12503. The following commit applies the methods broadly, reducing verbose test code where possible.

@mkamonMdt mkamonMdt requested a review from a team as a code owner November 30, 2024 21:34
@mkamonMdt mkamonMdt requested a review from akhi3030 November 30, 2024 21:35
@mkamonMdt
Copy link
Contributor Author

Hi, @wacban
That is the followup commit on InMemorySigner::test/test_signer methods refactor :)

Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for looking into it!

Some CI is failing in the nightly run, please fix and I'll merge it then. Repro should be something like the following:
just nextest nightly-slow

Two factory methods for InMemorySigner were provided in near#12503.
The following commit applies the methods broadly, reducing verbose
test code where possible.
@mkamonMdt mkamonMdt force-pushed the inmemorysigner_test_methods_apply branch from 0e8f1a0 to a720786 Compare December 1, 2024 20:08
@wacban wacban enabled auto-merge December 1, 2024 20:58
@wacban wacban added this pull request to the merge queue Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.04%. Comparing base (0194311) to head (a720786).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
test-utils/runtime-tester/src/scenario_builder.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12537      +/-   ##
==========================================
- Coverage   70.05%   70.04%   -0.01%     
==========================================
  Files         840      840              
  Lines      169738   169713      -25     
  Branches   169738   169713      -25     
==========================================
- Hits       118911   118882      -29     
- Misses      45690    45695       +5     
+ Partials     5137     5136       -1     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (ø)
db-migration 0.16% <0.00%> (ø)
genesis-check 1.29% <0.00%> (+<0.01%) ⬆️
linux 69.31% <81.25%> (+0.01%) ⬆️
linux-nightly 69.60% <81.25%> (-0.03%) ⬇️
pytests 1.59% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.40% <0.00%> (+<0.01%) ⬆️
unittests 69.86% <81.25%> (-0.01%) ⬇️
upgradability 0.20% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into near:master with commit 9f126e8 Dec 2, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants