Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(resharding): two independent splits #12762

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

staffik
Copy link
Contributor

@staffik staffik commented Jan 21, 2025

  • test_resharding_v3_two_independent_splits - tests basic scenario where we split two independent shards.
  • test_resharding_v3_two_splits_one_after_another_at_single_node - tries to reproduce the scenario that we have in recent forknet test, where one node tracks (first_parent) -> (first_parent_child, second_parent) -> (second_parent_child). (Un)fortunatelly, it passes too.

Double resharding (split child after first resharding) actually needs restarts and is not supported yet in testloop.

@staffik staffik requested a review from a team as a code owner January 21, 2025 10:31
@staffik staffik force-pushed the stafik/resharding/two-independent-splits branch from e6fd686 to 65ab722 Compare January 21, 2025 11:43
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.54%. Comparing base (9d97226) to head (39ccfa7).

Files with missing lines Patch % Lines
integration-tests/src/test_loop/utils/setups.rs 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12762      +/-   ##
==========================================
+ Coverage   70.51%   70.54%   +0.02%     
==========================================
  Files         846      846              
  Lines      174633   174682      +49     
  Branches   174633   174682      +49     
==========================================
+ Hits       123149   123228      +79     
+ Misses      46262    46229      -33     
- Partials     5222     5225       +3     
Flag Coverage Δ
backward-compatibility 0.16% <ø> (ø)
db-migration 0.16% <ø> (ø)
genesis-check 1.35% <ø> (?)
linux 68.89% <0.00%> (+0.01%) ⬆️
linux-nightly 70.12% <97.95%> (-0.01%) ⬇️
pytests 1.65% <ø> (+0.18%) ⬆️
sanity-checks 1.46% <ø> (ø)
unittests 70.38% <97.95%> (+<0.01%) ⬆️
upgradability 0.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@staffik staffik marked this pull request as draft January 21, 2025 13:31
@staffik staffik marked this pull request as ready for review January 21, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant