Bench improvement #1342
Closed
Bench improvement #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaksymZavershynskyi
suggested changes
Sep 26, 2019
| } | ||
| sum /= n as u128; |
There was a problem hiding this comment.
Why this line needed?
There was a problem hiding this comment.
Otherwise it overfits u64 for larger sums
| expected_value += (i * i) as u128; | ||
| } | ||
| expected_value /= n as u128; | ||
| group.bench_function(BenchmarkId::new("wasm", benchmark_param_display.clone()), |b| { |
There was a problem hiding this comment.
benchmark id should include name of the function, e.g. "sum_n"?
There was a problem hiding this comment.
the group has the name
MaksymZavershynskyi
added
the
A-transaction-runtime
|
@evgenykuzyakov Is this an abandoned PR? Should we close it? |
|
Sorry. It still worth to complete it. I just didn't get back to address the changes. Will take a look later this week. |
|
@evgenykuzyakov Did you have a chance to look at it? |
|
@evgenykuzyakov ping? |
|
We can probably close it since now we have |
|
It's also less useful, since it just runs wasm in isolation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch bencher to criterion. Update sum_n to do work instead of running pre-compiled code