Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade sysinfo to avoid too many open files bug #1952

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Jan 14, 2020

located this happens after new sysinfo::System::new(): GuillaumeGomez/sysinfo#242; before it fixed there it looks okay for us to use previous version.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #1952 into staging will decrease coverage by 0.15%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           staging   #1952      +/-   ##
==========================================
- Coverage    86.65%   86.5%   -0.16%     
==========================================
  Files          167     167              
  Lines        31447   31460      +13     
==========================================
- Hits         27251   27214      -37     
- Misses        4196    4246      +50
Impacted Files Coverage Δ
chain/chunks/src/types.rs 25% <ø> (ø) ⬆️
core/store/src/db.rs 87.7% <ø> (ø) ⬆️
runtime/near-vm-runner/src/prepare.rs 96.93% <100%> (-0.04%) ⬇️
chain/client/src/types.rs 82.03% <100%> (-0.09%) ⬇️
chain/client/src/info.rs 70% <100%> (-0.38%) ⬇️
runtime/near-vm-logic/src/logic.rs 93.9% <100%> (ø) ⬆️
runtime/near-vm-runner/src/runner.rs 95.74% <50%> (-2.04%) ⬇️
chain/chain/src/store.rs 88.35% <85.36%> (-0.1%) ⬇️
chain/chunks/src/lib.rs 93.82% <93.75%> (+0.14%) ⬆️
chain/client/src/client_actor.rs 86.53% <94.44%> (+0.4%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2e7a3...d5e2c4b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants