Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sysinfo as too many open files is fixed #1986

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Jan 20, 2020

As a follow up to this issue: #1942 (was fixed by downgrade sysinfo)
It's because of an optional optimization in sysinfo crate and now an option to turn off initial open files is added in GuillaumeGomez/sysinfo#243. To verify it's still good, find near's pid. lsof -p <pid> | wc -l. Also note this was only an issue for linux (the optimization was linux only)

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #1986 into staging will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1986      +/-   ##
===========================================
- Coverage    86.53%   86.52%   -0.01%     
===========================================
  Files          167      167              
  Lines        31818    31735      -83     
===========================================
- Hits         27535    27460      -75     
+ Misses        4283     4275       -8
Impacted Files Coverage Δ
chain/client/src/info.rs 70.27% <100%> (+0.27%) ⬆️
chain/network/src/test_utils.rs 94.18% <0%> (-2.33%) ⬇️
chain/client/tests/cross_shard_tx.rs 17.07% <0%> (-1.25%) ⬇️
chain/client/tests/query_client.rs 87.5% <0%> (-0.74%) ⬇️
...enesis-tools/genesis-csv-to-json/src/csv_parser.rs 68.34% <0%> (-0.43%) ⬇️
near/tests/sync_state_nodes.rs 55.14% <0%> (-0.42%) ⬇️
chain/jsonrpc/tests/http_query.rs 93.75% <0%> (-0.37%) ⬇️
chain/client/src/client_actor.rs 87.13% <0%> (-0.33%) ⬇️
chain/network/tests/cache.rs 93.15% <0%> (-0.28%) ⬇️
chain/chunks/src/lib.rs 93.6% <0%> (-0.19%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ad9bf...565f408. Read the comment docs.

@nearprotocol-bulldozer nearprotocol-bulldozer bot merged commit 509dde9 into staging Jan 20, 2020
@nearprotocol-bulldozer nearprotocol-bulldozer bot deleted the upgrade-sysinfo branch January 20, 2020 01:44
SkidanovAlex pushed a commit that referenced this pull request Jan 29, 2020
* Upgrade sysinfo as too many open files is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants