Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wasm] Add test for out-of-gas in the start function #2096

Closed
wants to merge 2 commits into from

Conversation

lexfrl
Copy link
Contributor

@lexfrl lexfrl commented Feb 5, 2020

No description provided.

@lexfrl lexfrl added the A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) label Feb 5, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #2096 into staging will decrease coverage by 0.17%.
The diff coverage is 81.92%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #2096      +/-   ##
===========================================
- Coverage    87.21%   87.03%   -0.18%     
===========================================
  Files          169      173       +4     
  Lines        33771    34119     +348     
===========================================
+ Hits         29454    29697     +243     
- Misses        4317     4422     +105
Impacted Files Coverage Δ
core/primitives/src/lib.rs 100% <ø> (ø) ⬆️
chain/client/tests/bug_repros.rs 92.59% <ø> (ø) ⬆️
chain/network/src/codec.rs 92.78% <ø> (ø) ⬆️
near/tests/sync_state_nodes.rs 55.55% <ø> (+0.41%) ⬆️
chain/client/src/sync.rs 88.27% <ø> (ø) ⬆️
chain/network/tests/cache.rs 93.24% <ø> (+0.09%) ⬆️
runtime/near-vm-runner/src/imports.rs 100% <ø> (ø) ⬆️
chain/client/src/lib.rs 0% <ø> (ø) ⬆️
chain/network/src/test_utils.rs 89.36% <ø> (-0.33%) ⬇️
chain/chain/src/finality.rs 91.62% <ø> (ø) ⬆️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9235f...cb9d30f. Read the comment docs.

@mikhailOK
Copy link
Contributor

we already had a test: test_infinite_initializer

@lexfrl
Copy link
Contributor Author

lexfrl commented Feb 5, 2020

The goal of this test is only to demonstrate that we got a right error type. Looks like test_infinite_initializer checks the same, so closing.

@lexfrl lexfrl closed this Feb 5, 2020
@chefsale chefsale deleted the fckt/test_simple_contract_start_out_of_gas branch June 4, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants