fix: prevent million-proposal attack by introducing minimum stake req… #2805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
requested review from
evgenykuzyakov,
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
|
|
frol
approved these changes
Jun 8, 2020
| /// The minimum stake required for staking is last seat price divided by this number. | ||
| #[serde(default = "default_minimum_stake_divisor")] | ||
| #[default(10)] | ||
| pub minimum_stake_divisor: u64, |
There was a problem hiding this comment.
How about using Rational instead of encoding the 1/divisor implicitly?
There was a problem hiding this comment.
I don't think that's needed (at least for now) because the stake is usually a large number (due to yotcoNEAR) and for example there would very little difference if we divide by 33 or multiple by 3/100.
evgenykuzyakov
approved these changes
Jun 10, 2020
SkidanovAlex
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uirements
Fixes #2610 in two parts:
Introduce a
minimum_stake_divisorto have a lower limit for staking transactions. If someone tries to stake with less thanlast_seat_price / minimum_stake_divisor, the transaction will fail.Instead of copying the proposals in every block info, use an aggregator that always updates the proposal information to the last final block and at the end of an epoch, process the rest between last final block and last block of the epoch.
Test plan
neard/src/runtimeto make sure that the proposals that are now invalid are properly rejected.