Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return experimental endpoint for light_client_proof RPC #2874

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

evgenykuzyakov
Copy link
Collaborator

Otherwise the current nearlib tests are failing, because they still depend on the EXPERIMENTAL_light_client_proof.
The proper migration should be first introducing light_client_proof then moving nearlib API to the new RPC endpoint. And once all chains are upgraded to the new endpoint, only then the EXPERIMENTAL endpoint can be deprecated.

Test plan:

  • CI

@evgenykuzyakov evgenykuzyakov requested a review from frol as a code owner June 19, 2020 22:47
@gitpod-io
Copy link

gitpod-io bot commented Jun 19, 2020

Copy link
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I somehow overlooked that.

@MaksymZavershynskyi
Copy link
Contributor

@evgenykuzyakov I agree that would be the proper way to do it, unfortunately we haven't done it for next_light_client_block so #2859 just resolved the inconsistency.

@nearprotocol-bulldozer nearprotocol-bulldozer bot merged commit 94f11d3 into master Jun 22, 2020
@nearprotocol-bulldozer nearprotocol-bulldozer bot deleted the return-experimental-endpoint branch June 22, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants