fix(client): fix trie_node_touched bug #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add read snapshots to storage and do refactoring where Trie instances are no longer persisted. Test plan --------- existing tests
mikhailOK
requested review from
lexfrl,
evgenykuzyakov,
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
|
|
ailisp
reviewed
Jul 22, 2020
| let mut guard = self.cache.lock().expect(POISONED_LOCK_ERR); | ||
| if let Some(val) = guard.cache_get(hash) { | ||
| Self::vec_to_rc(val) | ||
| // Ignore cache to be safe. retrieve_rc is used only when writing storage and cache is shared with readers. |
There was a problem hiding this comment.
but don't we write to storage quite frequently (every block)?
There was a problem hiding this comment.
most of the time retrieve_rc is called on new values, and we go to storage anyway
|
Is it possible to reproduce the panic from the linked issue within a test? |
bowenwang1996
approved these changes
Jul 23, 2020
evgenykuzyakov
approved these changes
Jul 23, 2020
bowenwang1996
pushed a commit
that referenced
this pull request
Jul 23, 2020
Change some code so that Trie instances are no longer persisted. Test plan --------- existing tests, new regression test
bowenwang1996
pushed a commit
that referenced
this pull request
Jul 28, 2020
Change some code so that Trie instances are no longer persisted. Test plan --------- existing tests, new regression test
matklad
reviewed
Dec 20, 2021
| @@ -226,6 +227,7 @@ impl DBTransaction { | |||
| pub struct RocksDB { | |||
| db: DB, | |||
| cfs: Vec<*const ColumnFamily>, | |||
| _pin: PhantomPinned, | |||
There was a problem hiding this comment.
What's was the intention of pining related changes here (adding PhantomPinned and Pin<dyn ...>)? On the first glance, it seems as if they don't do anything useful here.
There was a problem hiding this comment.
I'm simply worried that we mention such change the second time in two weeks. First was #5722.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add read snapshots to storage and do refactoring where
Trie instances are no longer persisted.
Fixes #3020
Test plan
existing tests