feat: Implicit account creation #3251

evgenykuzyakov · 2020-08-26T23:43:18Z

This PR implements near/NEPs#71

It contains a bunch of boilerplate code to pass the protocol version to VM and tests.

Logical changes:

Bumps protocol version to 35
Post protocol version, when a transfer action is executed on the 64-length hex like account ID as a single action in a transaction, it creates a new account if the account doesn't exist and add the ED25519 public key from the account ID hex representation.
If a CreateAccount action attempts to create 64-length hex like account, it fails.
Refunds don't automatically create accounts, because refunds are free and we don't want some type of abuse. NOTE: Account deletion with beneficiary creates a refund, so it'll not create a new account.
TransferAction fee cost on such 64-len hex accounts include CreateAction and AddFullAccessKey costs
The fee is also updated when calling a promise.
VMLogic::new change is backward compatible until we release a new near-sdk version. So it shouldn't break master after pushing it.
Bump near-vm-* versions to 2.2.0.

TODO:

Add integration test for transfer from promise
Add migration test for transfer to 64len
Uncomment VMLogic::new for near-sdk MockedBlockchain

Test plan:

CI
Added integration test and migration test

gitpod-io · 2020-08-26T23:43:22Z

codecov · 2020-08-27T20:14:32Z

Codecov Report

Merging #3251 into master will decrease coverage by 0.07%.
The diff coverage is 94.16%.

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
- Coverage   87.03%   86.96%   -0.08%     
==========================================
  Files         216      216              
  Lines       42119    42317     +198     
==========================================
+ Hits        36659    36800     +141     
- Misses       5460     5517      +57

Impacted Files	Coverage Δ
chain/chain/src/test_utils.rs	`91.29% <ø> (-0.93%)`	⬇️
chain/chain/src/types.rs	`95.83% <ø> (ø)`
core/primitives/src/version.rs	`100.00% <ø> (ø)`
neard/src/runtime.rs	`85.94% <0.00%> (-0.11%)`	⬇️
runtime/near-vm-logic/src/types.rs	`33.33% <ø> (ø)`
runtime/near-vm-runner/src/runner.rs	`100.00% <ø> (ø)`
runtime/near-vm-runner/tests/test_rs_contract.rs	`94.35% <ø> (ø)`
runtime/near-vm-runner/tests/test_ts_contract.rs	`96.22% <0.00%> (ø)`
runtime/near-vm-runner/tests/test_utils/mod.rs	`97.05% <ø> (ø)`
runtime/runtime-standalone/src/lib.rs	`94.84% <ø> (ø)`
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4f8d4...7873581. Read the comment docs.

…-accounts

evgenykuzyakov · 2020-08-28T17:23:23Z

runtime/runtime/src/lib.rs

- && action_receipt.signer_id == receipt.receiver_id
- {
- try_refund_allowance(
+ if let Some(account) = account.as_mut() {


Execution of transfer action

evgenykuzyakov · 2020-08-28T17:23:45Z

runtime/runtime/src/config.rs

@@ -132,7 +152,18 @@ pub fn exec_fee(config: &RuntimeFeesConfig, action: &Action) -> Gas {
 cfg.function_call_cost.exec_fee()
 + cfg.function_call_cost_per_byte.exec_fee() * num_bytes
 }
- Transfer(_) => cfg.transfer_cost.exec_fee(),
+ Transfer(_) => {


updated exec fees

evgenykuzyakov · 2020-08-28T17:23:51Z

runtime/runtime/src/config.rs

@@ -88,7 +92,18 @@ pub fn total_send_fees(
 cfg.function_call_cost.send_fee(sender_is_receiver)
 + cfg.function_call_cost_per_byte.send_fee(sender_is_receiver) * num_bytes
 }
- Transfer(_) => cfg.transfer_cost.send_fee(sender_is_receiver),
+ Transfer(_) => {


updated send fee

evgenykuzyakov · 2020-08-28T17:24:39Z

runtime/runtime/src/actions.rs

@@ -509,19 +552,47 @@ pub(crate) fn check_account_existence(
 action: &Action,


Logic for checking whether the current action is allowed.

evgenykuzyakov · 2020-08-28T17:24:57Z

runtime/runtime/src/actions.rs

@@ -343,6 +348,44 @@ pub(crate) fn action_create_account(
 });
 }

+pub(crate) fn action_implicit_account_creation_transfer(


Execution of transfer action with implicit account creation

evgenykuzyakov · 2020-08-28T17:25:35Z

runtime/near-vm-logic/src/logic.rs

@@ -1358,6 +1389,25 @@ impl<'a> VMLogic<'a> {

 let (receipt_idx, sir) = self.promise_idx_to_receipt_idx_with_sir(promise_idx)?;

+ if self.current_protocol_version >= IMPLICIT_ACCOUNT_CREATION_PROTOCOL_VERSION {


We charge more base fees for transfer on 64len hex account under new protocol

…-accounts

evgenykuzyakov · 2020-09-01T21:51:57Z

Please use my comments to navigate logical changes in the code

bowenwang1996

is there a surjection between ed25519 keypairs and byte arrays of length 32?

core/primitives/src/utils.rs

bowenwang1996 · 2020-09-01T22:27:20Z

runtime/near-vm-runner/benches/bench.rs

 use near_vm_logic::{ReturnData, VMConfig, VMContext, VMOutcome};
 use near_vm_runner::{run, VMError};

+const LATEST_PROTOCOL_VERSION: ProtocolVersion = ProtocolVersion::MAX;


Runner doesn't have primitives, so I can't use real protocol version.

I wonder if Bowen asked why do you need to introduce this const. It seems ProtocolVersion::MAX is quite descriptive to use it inline.

I see. @bowenwang1996 ?

I was wondering whether using max here can cause problems. For example if we have some function that requires doing arithmetic on protocol version it might easily overflow.

evgenykuzyakov · 2020-09-01T23:27:07Z

is there a surjection between ed25519 keypairs and byte arrays of length 32?

Aa part of InMemorySigner we just convert bytes to a secretkey. It may not be a valid ristretto, but it's okay for a full access key.

bowenwang1996

Can we run nightly tests on this PR?

runtime/near-vm-logic/src/utils.rs

frol · 2020-09-02T10:26:30Z

runtime/near-vm-runner/benches/bench.rs

 use near_vm_logic::{ReturnData, VMConfig, VMContext, VMOutcome};
 use near_vm_runner::{run, VMError};

+const LATEST_PROTOCOL_VERSION: ProtocolVersion = ProtocolVersion::MAX;


I wonder if Bowen asked why do you need to introduce this const. It seems ProtocolVersion::MAX is quite descriptive to use it inline.

runtime/runtime/src/actions.rs

runtime/runtime/src/config.rs

runtime/runtime/src/lib.rs

…-accounts

evgenykuzyakov · 2020-09-02T19:39:14Z

NayDuck run: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/286

This PR implements near/NEPs#71 It contains a bunch of boilerplate code to pass the protocol version to VM and tests. Logical changes: - Bumps protocol version to 35 - Post protocol version, when a transfer action is executed on the 64-length hex like account ID as a single action in a transaction, it creates a new account if the account doesn't exist and add the ED25519 public key from the account ID hex representation. - If a CreateAccount action attempts to create 64-length hex like account, it fails. - Refunds don't automatically create accounts, because refunds are free and we don't want some type of abuse. NOTE: Account deletion with beneficiary creates a refund, so it'll not create a new account. - `TransferAction` fee cost on such 64-len hex accounts include `CreateAction` and `AddFullAccessKey` costs - The fee is also updated when calling a promise. - `VMLogic::new` change is backward compatible until we release a new `near-sdk` version. So it shouldn't break master after pushing it. - Bump `near-vm-*` versions to `2.2.0`. TODO: - [x] Add integration test for transfer from promise - [x] Add migration test for transfer to 64len - [x] Uncomment `VMLogic::new` for `near-sdk` `MockedBlockchain` ## Test plan: - CI - Added integration test and migration test

Pass protocol versions

60b5364

Create accounts on account transfers

00e6d22

Evgeny Kuzyakov added 2 commits August 27, 2020 15:09

Add unit tests

14778b2

Merge branch 'master' of github.com:nearprotocol/nearcore into 64-len…

90a5c83

…-accounts

evgenykuzyakov commented Aug 28, 2020

View reviewed changes

Evgeny Kuzyakov added 7 commits August 31, 2020 11:30

Merge branch 'master' of github.com:nearprotocol/nearcore into 64-len…

0a95f8f

…-accounts

Add transfer to 64 hex test into runtime group tests

1fdf8ca

Merge branch 'master' of github.com:nearprotocol/nearcore into 64-len…

b7727f7

…-accounts

Update upgradability test

8c9c10f

Uncomment legacy VMLogic::new

352e64b

Update RPC error schema

17c66c0

Bump near-vm* versions

659ca1f

evgenykuzyakov changed the title ~~WIP: Pass protocol versions~~ feat: Implicit account creation Sep 1, 2020

evgenykuzyakov marked this pull request as ready for review September 1, 2020 21:51

evgenykuzyakov requested review from ailisp, bowenwang1996, frol, MaksymZavershynskyi, olonho, SkidanovAlex and willemneal as code owners September 1, 2020 21:51

evgenykuzyakov assigned bowenwang1996 Sep 1, 2020

bowenwang1996 reviewed Sep 1, 2020

View reviewed changes

bowenwang1996 reviewed Sep 2, 2020

View reviewed changes

frol approved these changes Sep 2, 2020

View reviewed changes

Address comments

55c4fcd

Evgeny Kuzyakov added 2 commits September 2, 2020 09:50

Merge branch 'master' of github.com:nearprotocol/nearcore into 64-len…

a887de7

…-accounts

Update publish to include utils

7873581

willemneal approved these changes Sep 2, 2020

View reviewed changes

bowenwang1996 approved these changes Sep 2, 2020

View reviewed changes

ailisp approved these changes Sep 2, 2020

View reviewed changes

evgenykuzyakov merged commit 9d759ad into master Sep 2, 2020

evgenykuzyakov deleted the 64-len-accounts branch September 2, 2020 21:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implicit account creation #3251

feat: Implicit account creation #3251

evgenykuzyakov commented Aug 26, 2020 •

edited

Loading

gitpod-io bot commented Aug 26, 2020 •

edited

Loading

codecov bot commented Aug 27, 2020 •

edited

Loading

evgenykuzyakov Aug 28, 2020

evgenykuzyakov Aug 28, 2020

evgenykuzyakov Aug 28, 2020

evgenykuzyakov Aug 28, 2020

evgenykuzyakov Aug 28, 2020

evgenykuzyakov Aug 28, 2020

evgenykuzyakov commented Sep 1, 2020

bowenwang1996 left a comment

bowenwang1996 Sep 1, 2020

evgenykuzyakov Sep 1, 2020

frol Sep 2, 2020

evgenykuzyakov Sep 2, 2020

bowenwang1996 Sep 2, 2020

evgenykuzyakov commented Sep 1, 2020

bowenwang1996 left a comment

frol Sep 2, 2020

evgenykuzyakov commented Sep 2, 2020

		@@ -509,19 +552,47 @@ pub(crate) fn check_account_existence(
		action: &Action,

		@@ -1358,6 +1389,25 @@ impl<'a> VMLogic<'a> {

		let (receipt_idx, sir) = self.promise_idx_to_receipt_idx_with_sir(promise_idx)?;

		if self.current_protocol_version >= IMPLICIT_ACCOUNT_CREATION_PROTOCOL_VERSION {

feat: Implicit account creation #3251

feat: Implicit account creation #3251

Conversation

evgenykuzyakov commented Aug 26, 2020 • edited Loading

Test plan:

gitpod-io bot commented Aug 26, 2020 • edited Loading

codecov bot commented Aug 27, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evgenykuzyakov commented Sep 1, 2020

bowenwang1996 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evgenykuzyakov commented Sep 1, 2020

bowenwang1996 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evgenykuzyakov commented Sep 2, 2020

evgenykuzyakov commented Aug 26, 2020 •

edited

Loading

gitpod-io bot commented Aug 26, 2020 •

edited

Loading

codecov bot commented Aug 27, 2020 •

edited

Loading