-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add precompiled contracts for alt_bn128 curve [rebased] #3971
Merged
Merged
Changes from 12 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
32f3aeb
add support for alt_bn128
snjax f5a7e54
Merge branch 'master' of github.com:near/nearcore into feature/alt_bn128
f8c5a9b
Merge
373515f
Wrapping some usage under features
2a49ed0
Updating param estimator. Re-format
40056a5
Merge branch 'master' of github.com:near/nearcore into feature/alt_bn…
9230405
Merge branch 'master' of github.com:near/nearcore into feature/alt_bn…
5e9425b
Update param estimator
280c40a
Upgrade bn
369076c
Merge branch 'master' of github.com:near/nearcore into feature/alt_bn…
b3115e8
Fix default for config
ad4d769
Add protocol_version fix to wasmer1 during rebase
846d599
Remove res dependencies
ab76546
Adding tests for alt-bn128
5aa4b94
Make used_gas test feature dependent
5597fb9
Compile contracts before param estimator
529fe4d
Fix target
2c94fe0
Remove nightly toolchain from build
dbcd949
Add stop on failure into build contract for param estimator
bef3d4f
Switch to cross-platform filesize
83c3cb8
Fixing evil_deep_recursion test. The contract was optimized (I guess)
38e1ff9
Obscure recursion
5339790
Fix used_gas test to be binary independent
0467955
Merge branch 'master' of github.com:near/nearcore into feature/alt_bn…
16ee715
Merge branch 'master' into feature/alt_bn128_fork
6dd1f39
Merge branch 'master' of github.com:near/nearcore into feature/alt_bn…
c47ea3f
Merge branch 'feature/alt_bn128_fork' of github.com:near/nearcore int…
122482c
Merge branch 'master' of github.com:near/nearcore into feature/alt_bn…
afa279f
Merge branch 'master' into feature/alt_bn128_fork
8cb3aec
Merge branch 'master' of github.com:near/nearcore into feature/alt_bn…
690ba81
Fix nightly protocol version and add nightly protocol to param estimator
f670142
Merge branch 'master' of github.com:near/nearcore into feature/alt_bn…
3db43a4
Merge branch 'feature/alt_bn128_fork' of github.com:near/nearcore int…
b61e614
Fix bash estimate.sh
de054e8
Merge branch 'master' of github.com:near/nearcore into feature/alt_bn…
56bfa56
Fix nightly_protocol_features
d02a523
Fix param estimator nightly + update the config
1bf0b1e
Merge branch 'master' of github.com:near/nearcore into feature/alt_bn…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,3 +26,4 @@ lazy_static = "1.4" | |
default = [] | ||
costs_counting = [] | ||
protocol_feature_evm = [] | ||
protocol_feature_alt_bn128 = [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be addressed in a refactor PR, but @matklad might know a way we can wrap all of these fields additions with just one flag instead of each.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just have an inner struct under feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, given that all these start with
alt_bn128_g1_
, it really wants to beregardless of a feature flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might break cost counter right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed that we'll refactor it later