Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Account versioning pytest fix #4141

Merged
merged 18 commits into from
Mar 23, 2021

Conversation

EgorKulikov
Copy link
Contributor

Fixes newly failed tests in nayduck

Copy link
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you also provide a link to some nayduck run here?

@mikhailOK
Copy link
Contributor

@bowenwang1996
Copy link
Collaborator

@EgorKulikov Please fix the test that @mikhailOK mentioned before merging your PR

@mikhailOK
Copy link
Contributor

pytest sanity/sync_chunks_from_archival.py --features nightly_protocol --features nightly_protocol_features http://nayduck.eastus.cloudapp.azure.com:3000/#/test/120005 - gets past genesis but still fails
pytest sanity/transactions.py --features nightly_protocol --features nightly_protocol_features http://nayduck.eastus.cloudapp.azure.com:3000/#/test/119969 - could be unrelated but looks suspicious

@EgorKulikov
Copy link
Contributor Author

pytest sanity/transactions.py --features nightly_protocol --features nightly_protocol_features http://nayduck.eastus.cloudapp.azure.com:3000/#/test/119969 - could be unrelated but looks suspicious

this one failed simillary before, see http://nayduck.eastus.cloudapp.azure.com:3000/#/test/115535
so it seems like this is just flaky

@mikhailOK
Copy link
Contributor

with #4135 transactions.py should be passing: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/1378

@EgorKulikov
Copy link
Contributor Author

with #4135 transactions.py should be passing: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/1378

Sorry, I think I've just ran that on unmerged master, that's the reason. I've restarted after merging

@EgorKulikov
Copy link
Contributor Author

EgorKulikov commented Mar 19, 2021

pytest sanity/sync_chunks_from_archival.py --features nightly_protocol --features nightly_protocol_features http://nayduck.eastus.cloudapp.azure.com:3000/#/test/120005 - gets past genesis but still fails

Seems like flaky test tbh - http://nayduck.eastus.cloudapp.azure.com:3000/#/test_history/120391
It either finishes in 100-110 seconds or timeouts out of 150 s

@mikhailOK
Copy link
Contributor

http://nayduck.eastus.cloudapp.azure.com:3000/#/test_history/118850 - looks less flaky before #4089, but maybe nayduck is slow today.

@EgorKulikov
Copy link
Contributor Author

with #4135 transactions.py should be passing: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/1378

passed after merging

@bowenwang1996
Copy link
Collaborator

bowenwang1996 commented Mar 23, 2021

@EgorKulikov is this ready to be merged? If so, feel free to merge it

@EgorKulikov
Copy link
Contributor Author

@bowenwang1996 I've made some additional changes since review, which probably need to be reviewed

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@near-bulldozer near-bulldozer bot merged commit cfc5a27 into master Mar 23, 2021
@near-bulldozer near-bulldozer bot deleted the account-versioning-pytest-fix branch March 23, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccountV1 pytest failures
4 participants