-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Account versioning pytest fix #4141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Could you also provide a link to some nayduck run here?
@EgorKulikov Please fix the test that @mikhailOK mentioned before merging your PR |
|
this one failed simillary before, see http://nayduck.eastus.cloudapp.azure.com:3000/#/test/115535 |
with #4135 transactions.py should be passing: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/1378 |
Sorry, I think I've just ran that on unmerged master, that's the reason. I've restarted after merging |
Seems like flaky test tbh - http://nayduck.eastus.cloudapp.azure.com:3000/#/test_history/120391 |
http://nayduck.eastus.cloudapp.azure.com:3000/#/test_history/118850 - looks less flaky before #4089, but maybe nayduck is slow today. |
passed after merging |
@EgorKulikov is this ready to be merged? If so, feel free to merge it |
@bowenwang1996 I've made some additional changes since review, which probably need to be reviewed |
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Fixes newly failed tests in nayduck