Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math API ecrecover and ripemd160 extension #4380

Merged
merged 163 commits into from
Jun 30, 2021
Merged

Math API ecrecover and ripemd160 extension #4380

merged 163 commits into from
Jun 30, 2021

Conversation

joshuajbouw
Copy link
Member

@joshuajbouw joshuajbouw commented Jun 20, 2021 •
edited
Loading

Summary

As a successor to #3954, this PR is meant to speed up and lower the cost of the Aurora EVM contract cost by adding several new methods to the nearcore Math API logic. Notably, ecrecover is extremely important as it is the most expensive method.

Todo

  • Removed blake2
  • Rework ecrecover to use near-crypto and not a new lib
  • Remove protocol_feature_evm conditional compilation which were added
  • Add protocol_feature_math_extension feature
  • Params estimator

References:

artob and others added 30 commits May 20, 2021 15:16
@artob @joshuajbouw
feat: Extend the Math API with EVM precompiles.
4101d54
@artob @joshuajbouw
feat: Add Math API stubs for ECRecover. (near#3921)
f1129da
@artob @joshuajbouw
test: Add RIPEMD-160 and BLAKE2b to the params estimator.
55291ee
@artob @matklad @joshuajbouw
fix: Improve error output from the params estimator.
e4aedd6 
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@artob @joshuajbouw
test: Add ECRecover stubs to the params estimator.
4b145d1
@artob @joshuajbouw
fix: Widen ecrecover() parameter type to pass CI checks.
f8461f7
@artob @joshuajbouw
feat(chain): Bump the protocol version.
becf003
@artob @joshuajbouw
feat(runtime): Implement ECRecover in the Math API. (near#3921)
4950ad3
@artob @joshuajbouw
docs: Document the ecrecover() function.
a5bbe0b
@artob @joshuajbouw
fix(chain): Guard protocol upgrade behind EVM feature.
2f88193
@joshuajbouw
add crypto feature gates
e97e6c6
@joshuajbouw
fix nightly compile
acb1440
@joshuajbouw
cargo fmt
773d818
@joshuajbouw
fix two ripemd160 missing feature gates
bdc0495
@joshuajbouw
rename crypto_extras feature to protocol_feature equivalents
b55fa0f
@joshuajbouw
change repo to our git
e6c389f
@joshuajbouw
put everything under protocol_feature_evm
fd0022a
@joshuajbouw
point to alternative blake2 branch temporarily
c1d77f0
@joshuajbouw
Add blake2b f function
f7ec5b1
@joshuajbouw
add blake2b_f to config
598b0c5
@joshuajbouw
post rebase fixes
16a32c8
@joshuajbouw
wrap all ext_costs in evm feature
e2b5e59
@joshuajbouw
add blake_2b_f to runtime estimator
ca3e329
@joshuajbouw
cargo fmt
188b9b8
@joshuajbouw
add new hash algos to feature
b0236f5
@joshuajbouw
add vm-logic test for blake2b_f
8945af7
@joshuajbouw
fix derive formatting
78ec861
@joshuajbouw
use same blake2 library
075e6be
@joshuajbouw
change blake F tests to test 1 round
d53a580
@joshuajbouw
fix blake f test
8da8c49
abacabadabacaba
abacabadabacaba requested changes Jun 26, 2021
View reviewed changes
core/crypto/src/signature.rs Outdated Show resolved Hide resolved
runtime/near-vm-logic/src/logic.rs Outdated Show resolved Hide resolved
@joshuajbouw
Copy link
Member Author

joshuajbouw commented Jun 29, 2021 •
edited
Loading

Provided CI is good to go, I just need the params estimator numbers, and good to push in. @nearmax @bowenwang1996

bowenwang1996
bowenwang1996 approved these changes Jun 29, 2021
View reviewed changes
Copy link
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need the new fees :)

@bowenwang1996 bowenwang1996 merged commit b0945d6 into near:master Jun 30, 2021
@joshuajbouw joshuajbouw deleted the feat/evm/math-extension branch June 30, 2021 10:22
@bowenwang1996 bowenwang1996 mentioned this pull request Jul 1, 2021
Closed
@joshuajbouw joshuajbouw mentioned this pull request Jul 2, 2021
Open
@birchmd birchmd mentioned this pull request Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell left review comments

@birchmd birchmd birchmd left review comments

@willemneal willemneal willemneal left review comments

@MaksymZavershynskyi MaksymZavershynskyi MaksymZavershynskyi approved these changes

@bowenwang1996 bowenwang1996 bowenwang1996 approved these changes

@evgenykuzyakov evgenykuzyakov Awaiting requested review from evgenykuzyakov

@frol frol Awaiting requested review from frol

@SkidanovAlex SkidanovAlex Awaiting requested review from SkidanovAlex

@matklad matklad Awaiting requested review from matklad

@EgorKulikov EgorKulikov Awaiting requested review from EgorKulikov

@ailisp ailisp Awaiting requested review from ailisp

@olonho olonho Awaiting requested review from olonho

@abacabadabacaba abacabadabacaba Awaiting requested review from abacabadabacaba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.