Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

count refund receipts toward gas limit calculation #4405

Merged
merged 14 commits into from
Jun 28, 2021
Merged

count refund receipts toward gas limit calculation #4405

merged 14 commits into from
Jun 28, 2021

Conversation

mzhangmzz
Copy link
Contributor

@mzhangmzz mzhangmzz commented Jun 23, 2021 •
edited
Loading

fix #4400

bowenwang1996
bowenwang1996 reviewed Jun 24, 2021
View reviewed changes
Copy link
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I think the test might be better written as an integration test (see process_blocks.rs)

runtime/runtime/src/lib.rs Outdated Show resolved Hide resolved
@EgorKulikov
Copy link
Contributor

As to PR in general - lgtm, but I agree with Bowen that integration test would be in order

bowenwang1996
bowenwang1996 approved these changes Jun 26, 2021
View reviewed changes
Copy link
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small issues

chain/client/tests/process_blocks.rs Outdated Show resolved Hide resolved
chain/client/tests/process_blocks.rs Outdated Show resolved Hide resolved
chain/client/tests/process_blocks.rs Outdated Show resolved Hide resolved
chain/client/tests/process_blocks.rs Outdated Show resolved Hide resolved
chain/client/tests/process_blocks.rs Outdated Show resolved Hide resolved
mzhangmzz and others added 4 commits June 27, 2021 17:55
@bowenwang1996
Copy link
Collaborator

@mzhangmzz looks like there are some conflicts you need to resolve

@mzhangmzz mzhangmzz merged commit cfed276 into master Jun 28, 2021
@mzhangmzz mzhangmzz deleted the refund branch June 28, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenwang1996 bowenwang1996 bowenwang1996 approved these changes

@EgorKulikov EgorKulikov EgorKulikov approved these changes

@evgenykuzyakov evgenykuzyakov Awaiting requested review from evgenykuzyakov

@frol frol Awaiting requested review from frol

@MaksymZavershynskyi MaksymZavershynskyi Awaiting requested review from MaksymZavershynskyi

@SkidanovAlex SkidanovAlex Awaiting requested review from SkidanovAlex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue for GHSA-r3c6-jwgp-p825
3 participants
@mzhangmzz @EgorKulikov @bowenwang1996