pytest: migrate away from using WASM blobs #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce reliance on WASM blobs stored in repository, convert the pytest/tests/sanity/rpc_state_changes.py test to use test-contract-rs, which is built from source, rather than hello.wasm contract. Issue: near#4408
To reduce reliance on WASM blobs stored in repository, convert the pytest/tests/sanity/rpc_tx_status.py test to use test-contract-rs, which is built from source, rather than hello.wasm contract. Issue: near#4408
…st-contract-rs To reduce reliance on WASM blobs stored in repository, convert the pytest/tests/sanity/rpc_light_client_execution_outcome_proof.py test to use test-contract-rs, which is built from source, rather than hello.wasm contract. Issue: near#4408
The add.wasm and singlepass_crash.wasm files have not been used for a while now and all uses of hello.wasm file has just been removed. All of those files can be safely removed. Fixes: near#4408
|
Nope. It’s only user was removed in 3978e02 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate all pytest tests which used hello.wasm contract (and thus
relied on a blob stored in the repository) to use test-contract-rs
instead (which is stored as source and built).
With that done, remove all WASM blobs stored in the tree. This
includes aforementioned hello.wasm as well as add.wasm and
singlepass_crash.wasm files.
Fixes: #4408