-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Recompute gas costs considering precompilation #4455
Conversation
Compile costs for worst runs: GCP (4 CPU, 16 GB RAM)
Local (6 CPU, 4 GB RAM)
It may worth attention that on local machine I often got a deviation in |
|
@Longarithm please provide a comparison between the new one and the current one. Similar to what @olonho did in #4231 |
Previous config was not valid, because I generated it using
|
Diff Generation:
Findings
|
This is definitely not correct. Data receipt creation should not cost 50Tgas. cc @olonho |
This PR has been automatically marked as stale because it has not had recent activity in the 2 weeks. |
The numeric value of the cost stays exactly the same (3856371 is evenly divisible by 3). Looking at the recent measurements in near#4455 (comment) it's clear that the measured cost is 3x lower.
The numeric value of the cost stays exactly the same (3856371 is evenly divisible by 3). Looking at the recent measurements in near#4455 (comment) it's clear that the measured cost is 3x lower.
The numeric value of the cost stays exactly the same (3856371 is evenly divisible by 3). Looking at the recent measurements in near#4455 (comment) it's clear that the measured cost is 3x lower.
The numeric value of the cost stays exactly the same (3856371 is evenly divisible by 3). Looking at the recent measurements in near#4455 (comment) it's clear that the measured cost is 3x lower.
The numeric value of the cost stays exactly the same (3856371 is evenly divisible by 3). Looking at the recent measurements in #4455 (comment) it's clear that the measured cost is 3x lower. Test Plan: -------- Just visual inspection that the constant stays the same.
The numeric value of the cost stays exactly the same (3856371 is evenly divisible by 3). Looking at the recent measurements in #4455 (comment) it's clear that the measured cost is 3x lower. Test Plan: -------- Just visual inspection that the constant stays the same.
Closing because the params-estimator logic changed a lot. |
Plan
Run
runtime-param-estimator
and updateRuntimeConfig
fees.