-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump borsh version #4730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely missed zeropool-bn thingy, but a quick look around revealed that we added it in #3971 which is based on #2842, which was authored by the maintainer of zeropool-bn crate: https://github.com/zeropoolnetwork/bn/blob/master/Cargo.toml
Not sure if it gets checked, but here is PR zeropoolnetwork/bn#1. Happy to wait for this to be resolved before pulling in to remove the 0.8 altogether. Perhaps we should just update the near fork to this? Or are we okay with using zeropool fork? cc @evgenykuzyakov as you added this |
Closes #4603
I think the zeropool_bn borsh version still needs to be updated. I'm still tracking down which fork is being published from because it doesn't seem to be the near or aurora fork of bn (can someone save me time and point in right direction?).
What I'm confused about is why the cargo-deny doesn't fail when specifying 0.9 borsh and checking ban conditions