-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rust-version
to Cargo configuration
#5530
Conversation
Add `package.rust-version` to all `Cargo.toml` files so that users don’t get mysterious compiler failures when trying to build the project with unsupported compilers. Issue: near#5452
rustc
is at least the version from rust-toolchain.toml
rust-version
to Cargo configuration
Example error
Not a huge fan of "remember to upgrade this config in ten different places" workflows, as most likely we won't be able to keep this consistent. But it's worth a try! |
(one alternative is to pin this only for, eg |
I'm of a similar opinion as @matklad. Having |
Of the most commonly depended on, I think the best candidate would be |
To clarify, given that we do publish things to crates IO (without much semver guarantees), I thing there might be some merit in just specifying this for everything. |
Looks like opinions are split regarding whether this should be just in |
As with every decision, there are benefits and drawbacks: Benefits:
Drawback:
I think we should do it. |
Add
package.rust-version
to allCargo.toml
files so that users don’tget mysterious compiler failures when trying to build the project with
unsupported compilers.
Issue: #5452