-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametrize max open files and col state cache size #6584
Parametrize max open files and col state cache size #6584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default on Debian and Ubuntu is 1024 RLIMIT_NOFILE so this will cause failures in production. If we’re increasing the count we should also set the limit at startup. I’m doing that in recompress_storage so we should use something similar at command startup.
@mina86 - AFAIK in production we already set the max open files to 65k (at least when running as systemctl). But yes, doing the increase in the code might be nice - as it will decrease number of failures on user side. What we could do @EdvardD - lower the value back to 512 in this PR - and afterwards send another PR That increases it to 10k and does the ulimit setting. |
I was thinking of only running the daemon but you're right the client can run it one-off. I returned 512 in this PR and will increase the number in the followup. |
Create store section in the neard config to pass various parameters to the store; Add max_open_files and ColState cache size parameters, Rework read_only store and enable statistics parameters.
Create store section in the neard config to pass various parameters to the store;
Add max_open_files and ColState cache size parameters,
Rework read_only store and enable statistics parameters.