Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize RocksDB block size #6631

Merged
merged 5 commits into from
Apr 20, 2022
Merged

Parameterize RocksDB block size #6631

merged 5 commits into from
Apr 20, 2022

Conversation

EdvardD
Copy link
Contributor

@EdvardD EdvardD commented Apr 19, 2022

We're still experimenting with block_size but it worth having parameterized in the current release

@EdvardD EdvardD requested a review from Longarithm April 19, 2022 10:17
@EdvardD EdvardD requested a review from a team as a code owner April 19, 2022 10:17
@EdvardD EdvardD requested a review from mzhangmzz April 19, 2022 10:17
Longarithm
Longarithm approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@Longarithm Longarithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add more context - we experiment with 4-32 KB values here, and for now it seems right to make validators able to adjust DB in case of abnormal load.

@EdvardD EdvardD merged commit 468895d into master Apr 20, 2022
@EdvardD EdvardD deleted the parametrize_block_size branch April 20, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzhangmzz mzhangmzz mzhangmzz approved these changes

@Longarithm Longarithm Longarithm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdvardD @Longarithm @mzhangmzz