feat/introduce cache related metrics for prometheus #7439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firatNEAR
changed the title
Longarithm
approved these changes
Aug 19, 2022
| @@ -43,10 +46,20 @@ impl TrieCache { | |||
| guard.put(hash, value.into()); | |||
| } | |||
There was a problem hiding this comment.
Suggested change
| } | |
| } else { | |
| metrics::SHARD_CACHE_TOO_LARGE.with_label_values(&labels).inc(); | |
| } |
We need to inc this metric here as well - this is my bug from the first impl
| @@ -34,7 +34,10 @@ impl TrieCache { | |||
| self.0.lock().expect(POISONED_LOCK_ERR).clear() | |||
| } | |||
|
|
|||
| pub fn update_cache(&self, ops: Vec<(CryptoHash, Option<&Vec<u8>>)>) { | |||
| pub fn update_cache(&self, ops: Vec<(CryptoHash, Option<&Vec<u8>>)>, shard_uid: ShardUId) { | |||
There was a problem hiding this comment.
Now I think that TrieCache should hold shard_uid, so we could avoid passing it here. Let's fix it in a separate PR
core/store/src/metrics.rs
Outdated
| pub static SHARD_CACHE_TOO_LARGE: Lazy<IntCounterVec> = Lazy::new(|| { | ||
| try_create_int_counter_vec( | ||
| "near_shard_cache_too_large", | ||
| "Shard cache too large", |
There was a problem hiding this comment.
Suggested change
| "Shard cache too large", | |
| "Number of too large values to be inserted into shard cache", |
core/store/src/trie/trie_storage.rs
Outdated
Comment on lines
255
to
265
| let shard_id_str = format!("{}", self.shard_uid.shard_id); | ||
| let is_view_str = format!("{}", self.is_view as u8); | ||
| let labels: [&str; 2] = [&shard_id_str, &is_view_str]; | ||
| { | ||
| metrics::CHUNK_CACHE_SIZE | ||
| .with_label_values(&labels) | ||
| .set(self.chunk_cache.borrow().len() as i64); | ||
| metrics::SHARD_CACHE_SIZE | ||
| .with_label_values(&labels) | ||
| .set(self.shard_cache.0.lock().expect(POISONED_LOCK_ERR).len() as i64); | ||
| } |
There was a problem hiding this comment.
Let's separate it to fn update_cache_size_metrics() for TrieCachingStorage and drop extra curly braces
There was a problem hiding this comment.
Sorry, I forgot that we use labels in this method below. Then the original code makes more sense
|
We decided to merge it with #7429, after finishing it we just close this one |
|
#742 is merged, should we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of cache metrics for monitoring.
Related issue #7375