store: return raw bytes from Trie::retrieve_node #7535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to merge near#7509
mina86
changed the title
mina86
approved these changes
Sep 2, 2022
|
By the way, I believe you need to Allow edits from maintainers: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork |
|
@blasrodri could do the above so that we can make this PR up-to-date with master and merge it? Basically, our infra requires three things to merge a PR:
I think if you yourself merge/rebase this PR to be up-to-date it should also get in, but keep an eye on the review status, sometimes it breaks when you push to the branch (but maybe I am imagining things? Don't know the exact rules github is using). |
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
This will be needed in future commit where we will need access to the raw bytes of the node. See #7509.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be needed in future commit where we will need access to the
raw bytes of the node. See #7509.