store: allow configuring RocksDB with support for subset of columns #7544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With cold storage approaching, it’s gonig to be necessary to be able to open RocksDB instance with only a subset of defined columns. Change how RocksDB deals with column family handles. Specifically, get_cf_handles now accepts an iterator over DBCol values as argument and cf_handle will return an error if trying to get a handle for a column that wasn’t set up.
matklad
reviewed
Sep 5, 2022
nikurt
approved these changes
Sep 5, 2022
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
…7544) With cold storage approaching, it’s gonig to be necessary to be able to open RocksDB instance with only a subset of defined columns. Change how RocksDB deals with column family handles. Specifically, get_cf_handles now accepts an iterator over DBCol values as argument and cf_handle will return an error if trying to get a handle for a column that wasn’t set up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With cold storage approaching, it’s gonig to be necessary to be able to
open RocksDB instance with only a subset of defined columns. Change how
RocksDB deals with column family handles. Specifically, get_cf_handles
now accepts an iterator over DBCol values as argument and cf_handle will
return an error if trying to get a handle for a column that wasn’t set
up.