feat: argument based prefetcher #7620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard rocksdb `flush()` only flushes the default column family. See https://github.com/facebook/rocksdb/blob/95ef007adc9365fbefc0f957722a191c1fd7dcd3/include/rocksdb/db.h#L1398-L1400 To flush all column families as intended, iterator over them and flush them individually.
Co-authored-by: Léo Gaspard <github@leo.gaspard.ninja>
- use crossbeam `ArrayQueue`
- this also fixes wrong usage of `BoundedQueue`
- put arc and mutex inside `PrefetchStagingArea`
- fixed false comments
- by default have prefetching disabled, allow enabling it with config - keep prefetcher and IO threads alive between chunks - use crossbeam bounded channel - remove stop_io atomic boolean - change some comments
- comments - avoid double lock of same mutex - handle prefetcher errors more gracefully
general prefetch was swapped with receipt prefetch
mm-near
reviewed
Sep 15, 2022
mm-near
approved these changes
Sep 15, 2022
nikurt
approved these changes
Sep 15, 2022
Ekleog-NEAR
approved these changes
Sep 15, 2022
- add comment about hack and when to remove it - call `slots.update_metrics()` in constructor
Co-authored-by: Ekleog-NEAR <96595974+Ekleog-NEAR@users.noreply.github.com>
Co-authored-by: Ekleog-NEAR <96595974+Ekleog-NEAR@users.noreply.github.com>
Co-authored-by: Ekleog-NEAR <96595974+Ekleog-NEAR@users.noreply.github.com>
Co-authored-by: Ekleog-NEAR <96595974+Ekleog-NEAR@users.noreply.github.com>
jakmeier
added a commit
to jakmeier/nearcore
that referenced
this pull request
Sep 15, 2022
Prefetcher that loads IO requests in parallel if the keys are listed in the smart contract function call argument. This is a experimental feature that has proven to stabilize mainnet nodes under current traffic. Especially when the node is not running with fast local SSDs. In the future we should generalize this implementation.
This was referenced Sep 15, 2022
Merged
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Prefetcher that loads IO requests in parallel if the keys are listed in the smart contract function call argument. This is a experimental feature that has proven to stabilize mainnet nodes under current traffic. Especially when the node is not running with fast local SSDs. In the future we should generalize this implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefetcher that loads IO requests in parallel if the keys are listed in the smart contract function call argument.
This is a experimental feature that has proven to stabilize mainnet nodes under current traffic. Especially when the node is not running with fast local SSDs.
In the future we should generalize this implementation.