refactor: prettify chunk management test #7659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
commented
Sep 21, 2022
| }); | ||
| Test { | ||
| validator_groups: 4, | ||
| chunk_only_producers: true, |
There was a problem hiding this comment.
Huh, this is an unintended bugfix I think, this would should be true
(which makes me more confident that we actually need this change :) )
There was a problem hiding this comment.
I'm not sure if chunk_only_producers would be true here. The naming for the rest of the tests seem to indicate that if chunk_only_producers is true, the name is the tests would end with _cop
There was a problem hiding this comment.
And this test does end with _cop
There was a problem hiding this comment.
Ie, it was wrongly false before.
There was a problem hiding this comment.
ah sorry I must have misread something
|
Ahh this is so much better. Thanks for the refactoring and fix! |
mzhangmzz
approved these changes
Sep 22, 2022
Adding an explicit "test fixture" struct makes call-sites more readable (named args!) and makes making further changes easier.
nikurt
pushed a commit
that referenced
this pull request
Sep 26, 2022
Adding an explicit "test fixture" struct makes call-sites more readable (named args!) and makes making further changes easier. No particular grand plan here, just figured this small change to be a marginal improvement!
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Adding an explicit "test fixture" struct makes call-sites more readable (named args!) and makes making further changes easier. No particular grand plan here, just figured this small change to be a marginal improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an explicit "test fixture" struct makes call-sites more readable (named args!) and makes making further changes easier.
No particular grand plan here, just figured this small change to be a marginal improvement!