Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always display uncertain estimation warnings #7690

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

jakmeier
Copy link
Contributor

resolves #7004, see that issue for reasoning behind the change

resolves near#7004, see that issue for reasoning behind the change
@jakmeier jakmeier added the A-params-estimator Area: runtime params estimator label Sep 26, 2022
@jakmeier jakmeier requested a review from matklad September 26, 2022 12:44
@jakmeier jakmeier requested a review from a team as a code owner September 26, 2022 12:44
Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Also gives some extra pressure to keep uncertains low

@near-bulldozer near-bulldozer bot merged commit 1386a41 into near:master Sep 26, 2022
nikurt pushed a commit that referenced this pull request Sep 27, 2022
resolves #7004, see that issue for reasoning behind the change
@jakmeier jakmeier deleted the ce-uncertain-warnings branch September 29, 2022 10:05
nikurt pushed a commit that referenced this pull request Nov 9, 2022
resolves #7004, see that issue for reasoning behind the change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-params-estimator Area: runtime params estimator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous estimation: Display uncertain warning in Zulip
2 participants