enabled TIER1 peer discovery in all envs #7759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-near
reviewed
Oct 4, 2022
mm-near
approved these changes
Oct 4, 2022
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Validators are already adding their public IPs to the configs (some correctly, some incorrectly) and this PR enables broadcasting this information to the network. It will allow us to monitor whether broadcasting works and check whether validators have correctly configured their public IPs. So far TIER1 peer discovery has been enabled in shardnet (while it still existed) and no regression has been observed. The TIER1 connections are still not established, the relevant code will be merged in another PR (possibly protected with a separate feature flag, and this flag will be renamed accordingly).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validators are already adding their public IPs to the configs (some correctly, some incorrectly) and this PR enables broadcasting this information to the network. It will allow us to monitor whether broadcasting works and check whether validators have correctly configured their public IPs. So far TIER1 peer discovery has been enabled in shardnet (while it still existed) and no regression has been observed.
The TIER1 connections are still not established, the relevant code will be merged in another PR (possibly protected with a separate feature flag, and this flag will be renamed accordingly).