Trace context for the following actors: #7819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ClientActor * ViewClientActor * TelemetryActor
nikurt
requested review from
mzhangmzz and
nagisa
and removed request for
mzhangmzz
nagisa
reviewed
Oct 14, 2022
…ntries (#7835) https://near.zulipchat.com/#narrow/stream/295558-pagoda.2Fcore/topic/DB.20migrate_32_to_33.20panics That's the only reason I could think of.
Co-authored-by: Akhilesh Singhania <akhi3030@gmail.com>
Previously, if neard wasn’t configured to run as an archival node (i.e. `archive` setting in `config.json` was false) but the database was an archive, the node would fail. Change this behaviour so that it warns and continues running as archival node. The grand plan is to get rid of the `archive` setting and have type of the node be determined by the database. This will reduce number of special cases to be handled when opening a database.
Thanks to @marcelo-gonzalez for providing the diff.
Replace RuntimeAdapter::get_store with RuntimeAdapter::store method which returns reference to a Store rather than cloning it. This avoids some instances where the Store is cloned unnecessarily.
* ClientActor * ViewClientActor * TelemetryActor
nagisa
reviewed
Oct 18, 2022
|
This is looking pretty clean so far! I love when the code becomes clearer as a result of adding functionality ^^ |
added 2 commits
October 18, 2022 14:41
…. For better formatting and readability.
nagisa
approved these changes
Oct 18, 2022
added 2 commits
October 18, 2022 15:44
nikurt
added a commit
that referenced
this pull request
Nov 9, 2022
* ClientActor * ViewClientActor * TelemetryActor Tested by running a mainnet node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by running a mainnet node with this PR.
This PR enriches the tracing information. With this change we can see which context generated the actix messages processed by ClientActor and ViewClientActor.
https://pagodaplatform.atlassian.net/browse/ND-171