Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: introduce cold storage #7871

Merged
merged 10 commits into from
Oct 25, 2022
Merged

store: introduce cold storage #7871

merged 10 commits into from
Oct 25, 2022

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Oct 19, 2022

Add a cold_store Cargo feature which enables the option to configure
the node with cold storage. At the moment, all this does is open the
cold database and doesn’t enable any other features. The idea is that
this can now allow experimenting with code that needs access to the
cold storage.

@mina86 mina86 requested a review from posvyatokum October 19, 2022 02:22
@mina86 mina86 requested a review from a team as a code owner October 19, 2022 02:22
@mina86 mina86 requested a review from akhi3030 October 19, 2022 02:22
@akhi3030
Copy link
Collaborator

@posvyatokum: I'm happy to approve once your reviews are in and you approve.

posvyatokum
posvyatokum approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@posvyatokum posvyatokum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, all my comments are about comments.

core/store/src/opener.rs Outdated Show resolved Hide resolved
core/store/src/opener.rs Outdated Show resolved Hide resolved
nearcore/src/lib.rs Outdated Show resolved Hide resolved
mina86 added 5 commits October 25, 2022 00:11
@mina86
review
0aa78ba
@mina86
Merge remote-tracking branch 'up/master' into HEAD
23d31db
@mina86
wip
70029af
@mina86
core: add chain Error → TxStatusError conversion (#7912)
80e3b72 
Having conversion from near_chain_primitves::Error to TxStatusError
eliminates a handful of trivial map_error calls.
@mina86
fmt
e836109
@near-bulldozer near-bulldozer bot merged commit 4bc5141 into master Oct 25, 2022
@near-bulldozer near-bulldozer bot deleted the mpn-cold branch October 25, 2022 11:35
nikurt pushed a commit that referenced this pull request Oct 25, 2022
@mina86 @nikurt
store: introduce cold storage (#7871)
15d06db 
Add a `cold_store` Cargo feature which enables the option to configure
the node with cold storage.  At the moment, all this does is open the
cold database and doesn’t enable any other features.  The idea is that
this can now allow experimenting with code that needs access to the
cold storage.
nikurt pushed a commit that referenced this pull request Nov 7, 2022
@mina86 @nikurt
store: introduce cold storage (#7871)
01d2fde 
Add a `cold_store` Cargo feature which enables the option to configure
the node with cold storage.  At the moment, all this does is open the
cold database and doesn’t enable any other features.  The idea is that
this can now allow experimenting with code that needs access to the
cold storage.
nikurt pushed a commit that referenced this pull request Nov 9, 2022
@mina86 @nikurt
store: introduce cold storage (#7871)
4da9b5e 
Add a `cold_store` Cargo feature which enables the option to configure
the node with cold storage.  At the moment, all this does is open the
cold database and doesn’t enable any other features.  The idea is that
this can now allow experimenting with code that needs access to the
cold storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posvyatokum posvyatokum posvyatokum approved these changes

@akhi3030 akhi3030 akhi3030 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mina86 @akhi3030 @posvyatokum